You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/06 06:31:08 UTC
[GitHub] [hudi] danny0405 commented on a change in pull request #4959: [MINOR][HUDI-3460]Fix HoodieDataSourceITCase
danny0405 commented on a change in pull request #4959:
URL: https://github.com/apache/hudi/pull/4959#discussion_r820187195
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -516,14 +514,6 @@ public static boolean haveSuccessfulCommits(HoodieTableMetaClient metaClient) {
* Returns the max compaction memory in bytes with given conf.
*/
public static long getMaxCompactionMemoryInBytes(Configuration conf) {
- if (conf.contains(FlinkOptions.COMPACTION_MAX_MEMORY)) {
- return conf.get(FlinkOptions.COMPACTION_MAX_MEMORY) * 1024 * 1024;
- }
- return (long)Math
- .ceil(conf.getDouble(FlinkOptions.COMPACTION_MEMORY_FRACTION_PROP)
- * TaskExecutorProcessUtils.processSpecFromConfig(
- TaskExecutorProcessUtils.getConfigurationMapLegacyTaskManagerHeapSizeToConfigOption(
- conf, TaskManagerOptions.TOTAL_PROCESS_MEMORY))
- .getManagedMemorySize().getBytes());
+ return conf.getInteger(FlinkOptions.COMPACTION_MAX_MEMORY) * 1024 * 1024;
Review comment:
May also need to delete the useless option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org