You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/22 05:27:59 UTC
[GitHub] [zookeeper] maoling opened a new pull request #1584: ZOOKEEPER-4186: update the developer list
maoling opened a new pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on a change in pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
ztzg commented on a change in pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#discussion_r563275856
##########
File path: pom.xml
##########
@@ -253,6 +253,36 @@
<email>eolivelli@apache.org</email>
<timezone>+1</timezone>
</developer>
+ <developer>
+ <id>nkalmar</id>
+ <name>Norbert Kalmar</name>
+ <email>nkalmar@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>enixon</id>
+ <name>Brian Nixon</name>
+ <email>enixon@apache.org</email>
+ <timezone>-8</timezone>
+ </developer>
+ <developer>
+ <id>symat</id>
+ <name>Mate Szalay-Beko</name>
+ <email>symat@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>ddiederen</id>
+ <name>Damien Diederen</name>
+ <email>ddiederen@apache.org</email>
+ <timezone>+2</timezone>
Review comment:
Ah, time zones. Never been a sticky topic in the history of computers (or the history of history), ever :)
I'm afraid I'm +1 (currently living in Munich). But that brought the question of DST (Daylight Saving Time), even if it's inactive right now.
Looking at https://maven.apache.org/pom.html#developers, I see:
> **timezone**: A valid time zone ID like `America/New_York` or `Europe/Berlin`, or a numerical offset in hours (and fraction) from UTC where the developer lives, e.g., `-5` or `+1`. Time zone IDs are highly preferred because they are not affected by DST and time zone shifts. […]
So: `<timezone>Europe/Berlin</timezone>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#issuecomment-766644353
Two votes. Commit to master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on a change in pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
ztzg commented on a change in pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#discussion_r563343610
##########
File path: pom.xml
##########
@@ -253,6 +253,36 @@
<email>eolivelli@apache.org</email>
<timezone>+1</timezone>
</developer>
+ <developer>
+ <id>nkalmar</id>
+ <name>Norbert Kalmar</name>
+ <email>nkalmar@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>enixon</id>
+ <name>Brian Nixon</name>
+ <email>enixon@apache.org</email>
+ <timezone>-8</timezone>
+ </developer>
+ <developer>
+ <id>symat</id>
+ <name>Mate Szalay-Beko</name>
+ <email>symat@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>ddiederen</id>
+ <name>Damien Diederen</name>
+ <email>ddiederen@apache.org</email>
+ <timezone>+2</timezone>
Review comment:
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#issuecomment-765134118
@ztzg PTAL :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on a change in pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
ztzg commented on a change in pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#discussion_r563343610
##########
File path: pom.xml
##########
@@ -253,6 +253,36 @@
<email>eolivelli@apache.org</email>
<timezone>+1</timezone>
</developer>
+ <developer>
+ <id>nkalmar</id>
+ <name>Norbert Kalmar</name>
+ <email>nkalmar@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>enixon</id>
+ <name>Brian Nixon</name>
+ <email>enixon@apache.org</email>
+ <timezone>-8</timezone>
+ </developer>
+ <developer>
+ <id>symat</id>
+ <name>Mate Szalay-Beko</name>
+ <email>symat@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>ddiederen</id>
+ <name>Damien Diederen</name>
+ <email>ddiederen@apache.org</email>
+ <timezone>+2</timezone>
Review comment:
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on a change in pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
maoling commented on a change in pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#discussion_r563301649
##########
File path: pom.xml
##########
@@ -253,6 +253,36 @@
<email>eolivelli@apache.org</email>
<timezone>+1</timezone>
</developer>
+ <developer>
+ <id>nkalmar</id>
+ <name>Norbert Kalmar</name>
+ <email>nkalmar@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>enixon</id>
+ <name>Brian Nixon</name>
+ <email>enixon@apache.org</email>
+ <timezone>-8</timezone>
+ </developer>
+ <developer>
+ <id>symat</id>
+ <name>Mate Szalay-Beko</name>
+ <email>symat@apache.org</email>
+ <timezone>+1</timezone>
+ </developer>
+ <developer>
+ <id>ddiederen</id>
+ <name>Damien Diederen</name>
+ <email>ddiederen@apache.org</email>
+ <timezone>+2</timezone>
Review comment:
Got it. Haha, I like this rigorous expression:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#issuecomment-765134118
@ztzg PTAL :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1584: ZOOKEEPER-4186: update the developer list
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1584:
URL: https://github.com/apache/zookeeper/pull/1584#issuecomment-766644353
Two votes. Commit to master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org