You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mi...@apache.org on 2014/07/14 15:27:38 UTC
[1/3] git commit: [flex-sdk] [refs/heads/develop] - Spelling and
logic improvements.
Repository: flex-sdk
Updated Branches:
refs/heads/develop facd8cec7 -> dc680bbfb
Spelling and logic improvements.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/3167e429
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/3167e429
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/3167e429
Branch: refs/heads/develop
Commit: 3167e429fa7051e40858a45f14c6ea433f630e40
Parents: 8a6efb4
Author: Mihai C <mi...@apache.org>
Authored: Wed Jul 2 17:32:42 2014 +0100
Committer: Mihai C <mi...@apache.org>
Committed: Wed Jul 2 17:35:08 2014 +0100
----------------------------------------------------------------------
README | 4 ++--
env-template.properties | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3167e429/README
----------------------------------------------------------------------
diff --git a/README b/README
index f5c47d6..1f17d23 100644
--- a/README
+++ b/README
@@ -320,7 +320,7 @@ Adobe Flash Player Version Support
Change the playerglobal.version in the build.properties file to have a value
other than "11.1". For this change to take effect the SDK needs to be
recompiled. For example to compile against the latest version of the Adobe
- Flash Player set the value of playerglobal.version to be "12.0" like so:
+ Flash Player set the value of playerglobal.version to be "13.0" like so:
playerglobal.version = 13.0
@@ -399,7 +399,7 @@ Adobe Flash Player Version Support
release.
It compiles against other Adobe Flash Player versions and is expected to
- work but their may be some issues, particularly with the earlier 10.2 and
+ work but there may be some issues, particularly with the earlier 10.2 and
10.3 versions of the Adobe Flash Player.
Software Dependencies
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/3167e429/env-template.properties
----------------------------------------------------------------------
diff --git a/env-template.properties b/env-template.properties
index d1465ca..ab7cb89 100644
--- a/env-template.properties
+++ b/env-template.properties
@@ -17,7 +17,7 @@
##
################################################################################
-# If you chose to use this file rename it to env.properties and uncomment the
+# If you choose to use this file, rename it to env.properties and uncomment the
# properties you wish to set.
# For each of
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Mihai Chira <mi...@gmail.com>.
Good to know, thanks.
On 14 July 2014 18:41, Alex Harui <ah...@adobe.com> wrote:
> IMO, that's expected. The other commit emails contain the details that we
> want to review. No need to try to amend commit messages.
>
> From: Mihai Chira <mi...@apache.org>
> Reply-To: "dev@flex.apache.org" <de...@flex.apache.org>
> Date: Monday, July 14, 2014 6:32 AM
> Cc: "commits@flex.apache.org" <co...@flex.apache.org>
> Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge
> branch 'FLEX-34385' into develop
>
> Hmm, I guess I should have edited the commit message to something more
> useful than "Merge branch 'FLEX-34385' into develop". How should I do that
> next time? Using commit --amend -m after merging my feature branch onto
> develop?
>
>
> On 14 July 2014 14:27, <mi...@apache.org> wrote:
>>
>> Merge branch 'FLEX-34385' into develop
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
>>
>> Branch: refs/heads/develop
>> Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
>> Parents: facd8ce 16d30c9
>> Author: Mihai C <mi...@apache.org>
>> Authored: Mon Jul 14 14:17:40 2014 +0100
>> Committer: Mihai C <mi...@apache.org>
>> Committed: Mon Jul 14 14:17:40 2014 +0100
>>
>> ----------------------------------------------------------------------
>> README | 4 ++--
>> env-template.properties | 2 +-
>> frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
>> 3 files changed, 9 insertions(+), 3 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Mihai Chira <mi...@gmail.com>.
Good to know, thanks.
On 14 July 2014 18:41, Alex Harui <ah...@adobe.com> wrote:
> IMO, that's expected. The other commit emails contain the details that we
> want to review. No need to try to amend commit messages.
>
> From: Mihai Chira <mi...@apache.org>
> Reply-To: "dev@flex.apache.org" <de...@flex.apache.org>
> Date: Monday, July 14, 2014 6:32 AM
> Cc: "commits@flex.apache.org" <co...@flex.apache.org>
> Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge
> branch 'FLEX-34385' into develop
>
> Hmm, I guess I should have edited the commit message to something more
> useful than "Merge branch 'FLEX-34385' into develop". How should I do that
> next time? Using commit --amend -m after merging my feature branch onto
> develop?
>
>
> On 14 July 2014 14:27, <mi...@apache.org> wrote:
>>
>> Merge branch 'FLEX-34385' into develop
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
>>
>> Branch: refs/heads/develop
>> Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
>> Parents: facd8ce 16d30c9
>> Author: Mihai C <mi...@apache.org>
>> Authored: Mon Jul 14 14:17:40 2014 +0100
>> Committer: Mihai C <mi...@apache.org>
>> Committed: Mon Jul 14 14:17:40 2014 +0100
>>
>> ----------------------------------------------------------------------
>> README | 4 ++--
>> env-template.properties | 2 +-
>> frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
>> 3 files changed, 9 insertions(+), 3 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Alex Harui <ah...@adobe.com>.
IMO, that's expected. The other commit emails contain the details that we want to review. No need to try to amend commit messages.
From: Mihai Chira <mi...@apache.org>>
Reply-To: "dev@flex.apache.org<ma...@flex.apache.org>" <de...@flex.apache.org>>
Date: Monday, July 14, 2014 6:32 AM
Cc: "commits@flex.apache.org<ma...@flex.apache.org>" <co...@flex.apache.org>>
Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch 'FLEX-34385' into develop
Hmm, I guess I should have edited the commit message to something more useful than "Merge branch 'FLEX-34385' into develop". How should I do that next time? Using commit --amend -m after merging my feature branch onto develop?
On 14 July 2014 14:27, <mi...@apache.org>> wrote:
Merge branch 'FLEX-34385' into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
Branch: refs/heads/develop
Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
Parents: facd8ce 16d30c9
Author: Mihai C <mi...@apache.org>>
Authored: Mon Jul 14 14:17:40 2014 +0100
Committer: Mihai C <mi...@apache.org>>
Committed: Mon Jul 14 14:17:40 2014 +0100
----------------------------------------------------------------------
README | 4 ++--
env-template.properties | 2 +-
frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
3 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Alex Harui <ah...@adobe.com>.
IMO, that's expected. The other commit emails contain the details that we want to review. No need to try to amend commit messages.
From: Mihai Chira <mi...@apache.org>>
Reply-To: "dev@flex.apache.org<ma...@flex.apache.org>" <de...@flex.apache.org>>
Date: Monday, July 14, 2014 6:32 AM
Cc: "commits@flex.apache.org<ma...@flex.apache.org>" <co...@flex.apache.org>>
Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch 'FLEX-34385' into develop
Hmm, I guess I should have edited the commit message to something more useful than "Merge branch 'FLEX-34385' into develop". How should I do that next time? Using commit --amend -m after merging my feature branch onto develop?
On 14 July 2014 14:27, <mi...@apache.org>> wrote:
Merge branch 'FLEX-34385' into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
Branch: refs/heads/develop
Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
Parents: facd8ce 16d30c9
Author: Mihai C <mi...@apache.org>>
Authored: Mon Jul 14 14:17:40 2014 +0100
Committer: Mihai C <mi...@apache.org>>
Committed: Mon Jul 14 14:17:40 2014 +0100
----------------------------------------------------------------------
README | 4 ++--
env-template.properties | 2 +-
frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
3 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Mihai Chira <mi...@apache.org>.
Hmm, I guess I should have edited the commit message to something more
useful than "Merge branch 'FLEX-34385' into develop". How should I do that
next time? Using commit --amend -m after merging my feature branch onto
develop?
On 14 July 2014 14:27, <mi...@apache.org> wrote:
> Merge branch 'FLEX-34385' into develop
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
>
> Branch: refs/heads/develop
> Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
> Parents: facd8ce 16d30c9
> Author: Mihai C <mi...@apache.org>
> Authored: Mon Jul 14 14:17:40 2014 +0100
> Committer: Mihai C <mi...@apache.org>
> Committed: Mon Jul 14 14:17:40 2014 +0100
>
> ----------------------------------------------------------------------
> README | 4 ++--
> env-template.properties | 2 +-
> frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
> 3 files changed, 9 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
>
>
>
[3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by mi...@apache.org.
Merge branch 'FLEX-34385' into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
Branch: refs/heads/develop
Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
Parents: facd8ce 16d30c9
Author: Mihai C <mi...@apache.org>
Authored: Mon Jul 14 14:17:40 2014 +0100
Committer: Mihai C <mi...@apache.org>
Committed: Mon Jul 14 14:17:40 2014 +0100
----------------------------------------------------------------------
README | 4 ++--
env-template.properties | 2 +-
frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
3 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34385
documenting unusual try-catch behaviour after event dispatch.
Posted by Mihai Chira <mi...@apache.org>.
Please let me know if that explanation is clear enough, or if you
think it should be put somewhere else.
On 14 July 2014 14:27, <mi...@apache.org> wrote:
> FLEX-34385 documenting unusual try-catch behaviour after event dispatch.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/16d30c9c
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/16d30c9c
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/16d30c9c
>
> Branch: refs/heads/develop
> Commit: 16d30c9c00c4689aa60a73968550d5af2b7b0373
> Parents: 3167e42
> Author: Mihai C <mi...@apache.org>
> Authored: Wed Jul 2 17:46:34 2014 +0100
> Committer: Mihai C <mi...@apache.org>
> Committed: Wed Jul 2 17:46:34 2014 +0100
>
> ----------------------------------------------------------------------
> frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
> 1 file changed, 6 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/16d30c9c/frameworks/projects/framework/src/mx/core/UIComponent.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/framework/src/mx/core/UIComponent.as b/frameworks/projects/framework/src/mx/core/UIComponent.as
> index 06ae586..7432f52 100644
> --- a/frameworks/projects/framework/src/mx/core/UIComponent.as
> +++ b/frameworks/projects/framework/src/mx/core/UIComponent.as
> @@ -13659,6 +13659,12 @@ public class UIComponent extends FlexSprite
> * Dispatches an event into the event flow.
> * The event target is the EventDispatcher object upon which
> * the <code>dispatchEvent()</code> method is called.
> + *
> + * Note that when <code>dispatchEvent()</code> is called by code inside a
> + * <code>try</code> block, any error thrown thereafter can be caught by
> + * listening to LoaderInfo.uncaughtErrorEvents. It will NOT reach the
> + * <code>catch</code> block.
> + *
> *
> * @param event The Event object that is dispatched into the event flow.
> * If the event is being redispatched, a clone of the event is created automatically.
>
[2/3] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34385
documenting unusual try-catch behaviour after event dispatch.
Posted by mi...@apache.org.
FLEX-34385 documenting unusual try-catch behaviour after event dispatch.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/16d30c9c
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/16d30c9c
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/16d30c9c
Branch: refs/heads/develop
Commit: 16d30c9c00c4689aa60a73968550d5af2b7b0373
Parents: 3167e42
Author: Mihai C <mi...@apache.org>
Authored: Wed Jul 2 17:46:34 2014 +0100
Committer: Mihai C <mi...@apache.org>
Committed: Wed Jul 2 17:46:34 2014 +0100
----------------------------------------------------------------------
frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/16d30c9c/frameworks/projects/framework/src/mx/core/UIComponent.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/core/UIComponent.as b/frameworks/projects/framework/src/mx/core/UIComponent.as
index 06ae586..7432f52 100644
--- a/frameworks/projects/framework/src/mx/core/UIComponent.as
+++ b/frameworks/projects/framework/src/mx/core/UIComponent.as
@@ -13659,6 +13659,12 @@ public class UIComponent extends FlexSprite
* Dispatches an event into the event flow.
* The event target is the EventDispatcher object upon which
* the <code>dispatchEvent()</code> method is called.
+ *
+ * Note that when <code>dispatchEvent()</code> is called by code inside a
+ * <code>try</code> block, any error thrown thereafter can be caught by
+ * listening to LoaderInfo.uncaughtErrorEvents. It will NOT reach the
+ * <code>catch</code> block.
+ *
*
* @param event The Event object that is dispatched into the event flow.
* If the event is being redispatched, a clone of the event is created automatically.