You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/14 07:29:46 UTC
[GitHub] [apisix] membphis commented on a change in pull request #6107: fix(ssl): radixtree_sni.lua
membphis commented on a change in pull request #6107:
URL: https://github.com/apache/apisix/pull/6107#discussion_r784611805
##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -104,7 +104,7 @@ local function set_pem_ssl_key(sni, cert, pkey)
end
local parsed_pkey, err = apisix_ssl.fetch_pkey(sni, pkey)
- if not parsed_cert then
+ if not parsed_pkey then
return false, "failed to parse PEM priv key: " .. err
Review comment:
do you have time to add a test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org