You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Geek-He <gi...@git.apache.org> on 2017/07/04 07:43:53 UTC
[GitHub] spark pull request #18526: [SPARK-21298][spark core]Don't need to modified n...
GitHub user Geek-He opened a pull request:
https://github.com/apache/spark/pull/18526
[SPARK-21298][spark core]Don't need to modified name when it's added the same ids
## What changes were proposed in this pull request?
It's not need to replace name when the key has exsited.
I have a stage,named freedom and id is 0, then adding a stage that named nofreedom and id is 0. In this case, i think it's not need to modified the stage name. returns existing values only.
## How was this patch tested?
Unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Geek-He/spark dev_0704
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18526.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18526
----
commit e6f6243033cf1418c7ccde77de4086dcb378be47
Author: he.qiao <he...@zte.com.cn>
Date: 2017-07-04T07:31:34Z
Don't need to modified name when it's added the same ids
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18526: [SPARK-21298][spark core]Don't need to modified n...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18526#discussion_r125646087
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala ---
@@ -60,7 +60,7 @@ class StorageListener(storageStatusListener: StorageStatusListener) extends Bloc
override def onStageSubmitted(stageSubmitted: SparkListenerStageSubmitted): Unit = synchronized {
val rddInfos = stageSubmitted.stageInfo.rddInfos
- rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info).name = info.name }
+ rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info)}
--- End diff --
That's the question to you -- why _don't_ you just want to do that?. You're actually reverting the change in SPARK-9044 (use `git blame` to understand who changed this and when.).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18526: [SPARK-21298][spark core]Don't need to modified n...
Posted by Geek-He <gi...@git.apache.org>.
Github user Geek-He commented on a diff in the pull request:
https://github.com/apache/spark/pull/18526#discussion_r125455747
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala ---
@@ -60,7 +60,7 @@ class StorageListener(storageStatusListener: StorageStatusListener) extends Bloc
override def onStageSubmitted(stageSubmitted: SparkListenerStageSubmitted): Unit = synchronized {
val rddInfos = stageSubmitted.stageInfo.rddInfos
- rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info).name = info.name }
+ rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info)}
--- End diff --
In the case that the ID existed, the other member of the whole info object is not updated, so why do you want to update the member name individually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18526: [SPARK-21298][spark core]Don't need to modified n...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18526#discussion_r125449878
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala ---
@@ -60,7 +60,7 @@ class StorageListener(storageStatusListener: StorageStatusListener) extends Bloc
override def onStageSubmitted(stageSubmitted: SparkListenerStageSubmitted): Unit = synchronized {
val rddInfos = stageSubmitted.stageInfo.rddInfos
- rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info).name = info.name }
+ rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info)}
--- End diff --
It's not clear this is valid. You are updating the whole info object, not just the name, in the case that the ID existed. Why is this needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18526: [SPARK-21298][spark core]Don't need to modified n...
Posted by Geek-He <gi...@git.apache.org>.
Github user Geek-He closed the pull request at:
https://github.com/apache/spark/pull/18526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18526: [SPARK-21298][spark core]Don't need to modified name whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18526
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18526: [SPARK-21298][spark core]Don't need to modified name whe...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18526
Since this is not a bug, could you please close this? @Geek-He Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18526: [SPARK-21298][spark core]Don't need to modified name whe...
Posted by Geek-He <gi...@git.apache.org>.
Github user Geek-He commented on the issue:
https://github.com/apache/spark/pull/18526
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org