You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/02/21 03:18:51 UTC

Review Request 18340: Renamed getJobSummary call to getRoleSummary

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18340/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-64
    https://issues.apache.org/jira/browse/AURORA-64


Repository: aurora


Description
-------

getJobSummary will be reused to return the jobs.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f7e34d1cf379168be6fffab0faaf450151a10bc 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js a0385e95c8c1fc950f507511377dcebe35f258a7 
  src/main/thrift/org/apache/aurora/gen/api.thrift 43a24969887b891339c97d4a0a055488c9188a5d 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 656e44eb51508c7ab05af8b91e9dcec216d48984 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java b4f7775033b8f865dbc2bc2821eb8e1350235e66 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 10f5cdab16230e66ac7c9fab199e2dd2564248da 

Diff: https://reviews.apache.org/r/18340/diff/


Testing
-------

gradle clean build
gradle run and tested on my laptop


Thanks,

Suman Karumuri


Re: Review Request 18340: Renamed getJobSummary call to getRoleSummary

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18340/#review35197
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Feb. 21, 2014, 2:18 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18340/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 2:18 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-64
>     https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> getJobSummary will be reused to return the jobs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js a0385e95c8c1fc950f507511377dcebe35f258a7 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 43a24969887b891339c97d4a0a055488c9188a5d 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java b4f7775033b8f865dbc2bc2821eb8e1350235e66 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 10f5cdab16230e66ac7c9fab199e2dd2564248da 
> 
> Diff: https://reviews.apache.org/r/18340/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> gradle run and tested on my laptop
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>