[GitHub] [superset] rusackas commented on a change in pull request #13736: test: DataTablesPane

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r602026370



##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -255,7 +255,7 @@ export const DataTablesPane = ({
   };
 
   return (
-    <SouthPane>
+    <SouthPane data-test="DataTablesPane">

Review comment:
       Ahh, this is a little counter to my comment/thought on that thread. In the linked example, the data-test attr uses the compnent name _inside_ the component (at the outer DOM layer), so any instance of the component will have that data-test attr. I'm fine with that.
   
   In this case, this is a _particular, purposeful instance_ of _a_ SouthPane component. In this case, I think we should follow the convention and go with the `data-test="some-purposeful-instance"` convention.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org