You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/13 02:35:51 UTC

[GitHub] [spark] xinrong-databricks opened a new pull request, #37168: [SPARK-39756][PYTHON] Better error messages for missing pandas scalars

xinrong-databricks opened a new pull request, #37168:
URL: https://github.com/apache/spark/pull/37168

   ### What changes were proposed in this pull request?
   pandas scalars are not reimplemented in pandas API on Spark intentionally.
   
   Users may use pandas scalars in pandas API on Spark directly.
   
   However, error messages are confusing when users mistakenly assume pandas scalars are reimplemented, for example, calling `ps.Timedelta`.
   
   
   ### Why are the changes needed?
   Better error messages should be clear and tell how to fix the errors.
   That can enhance usability, debuggability, and furthermore, user adoption.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. Error messages change. For example:
   
   
   ### How was this patch tested?
   Unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #37168: [SPARK-39756][PS] Better error messages for missing pandas scalars

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37168: [SPARK-39756][PS] Better error messages for missing pandas scalars
URL: https://github.com/apache/spark/pull/37168


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] xinrong-meng commented on pull request #37168: [SPARK-39756][PYTHON] Better error messages for missing pandas scalars

Posted by GitBox <gi...@apache.org>.
xinrong-meng commented on PR #37168:
URL: https://github.com/apache/spark/pull/37168#issuecomment-1184692128

   Hi @HyukjinKwon @ueshin, I adjusted error messages for clarity, would you take another look? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #37168: [SPARK-39756][PYTHON] Better error messages for missing pandas scalars

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37168:
URL: https://github.com/apache/spark/pull/37168#issuecomment-1184447364

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #37168: [SPARK-39756][PYTHON] Better error messages for missing pandas scalars

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37168:
URL: https://github.com/apache/spark/pull/37168#issuecomment-1182759428

   cc @ueshin FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #37168: [SPARK-39756][PS] Better error messages for missing pandas scalars

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37168:
URL: https://github.com/apache/spark/pull/37168#issuecomment-1186112508

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org