You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2019/10/01 19:28:00 UTC

[jira] [Commented] (RATIS-698) RaftServerImpl should not enforce minTimeout before first leaderElection cycle

    [ https://issues.apache.org/jira/browse/RATIS-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942258#comment-16942258 ] 

Hadoop QA commented on RATIS-698:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 59s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 88m 32s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
|   | ratis.examples.filestore.TestFileStoreWithGrpc |
|   | ratis.TestMultiRaftGroup |
|   | ratis.examples.filestore.TestFileStoreWithNetty |
|   | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.grpc.TestServerRestartWithGrpc |
|   | ratis.grpc.TestInstallSnapshotNotificationWithGrpc |
|   | ratis.netty.TestRaftReconfigurationWithNetty |
|   | ratis.grpc.TestStateMachineShutdownWithGrpc |
|   | ratis.grpc.TestRaftExceptionWithGrpc |
|   | ratis.server.simulation.TestGroupInfoWithSimulatedRpc |
|   | ratis.TestRaftServerNoLeaderTimeout |
|   | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
|   | ratis.grpc.TestWatchRequestWithGrpc |
|   | ratis.server.simulation.TestRetryCacheWithSimulatedRpc |
|   | ratis.netty.TestRaftStateMachineExceptionWithNetty |
|   | ratis.netty.TestGroupInfoWithNetty |
|   | ratis.netty.TestRetryCacheWithNettyRpc |
|   | ratis.grpc.TestRetryCacheWithGrpc |
|   | ratis.grpc.TestLeaderElectionWithGrpc |
|   | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
|   | ratis.netty.TestGroupManagementWithNetty |
|   | ratis.statemachine.TestStateMachine |
|   | ratis.netty.TestRaftSnapshotWithNetty |
|   | ratis.server.simulation.TestRaftExceptionWithSimulation |
|   | ratis.grpc.TestRaftWithGrpc |
|   | ratis.grpc.TestGroupInfoWithGrpc |
|   | ratis.server.raftlog.TestRaftLogMetrics |
|   | ratis.grpc.TestRaftAsyncWithGrpc |
|   | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
|   | ratis.grpc.TestRaftServerWithGrpc |
|   | ratis.netty.TestRaftWithNetty |
|   | ratis.server.simulation.TestGroupManagementWithSimulatedRpc |
|   | ratis.grpc.TestGroupManagementWithGrpc |
|   | ratis.grpc.TestRaftReconfigurationWithGrpc |
|   | ratis.netty.TestLeaderElectionWithNetty |
|   | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
|   | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
|   | ratis.netty.TestRaftExceptionWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.2 Server=19.03.2 Image:yetus/ratis:date2019-10-01 |
| JIRA Issue | RATIS-698 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12981916/RATIS-698.01.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  checkstyle  compile  |
| uname | Linux 069c05a72388 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build@2/yetus-personality.sh |
| git revision | master / ecef287 |
| maven | version: Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/1018/artifact/out/patch-unit-root.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/1018/testReport/ |
| Max. process+thread count | 4880 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/1018/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> RaftServerImpl should not enforce minTimeout before first leaderElection cycle
> ------------------------------------------------------------------------------
>
>                 Key: RATIS-698
>                 URL: https://issues.apache.org/jira/browse/RATIS-698
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 0.4.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>            Priority: Major
>             Fix For: 0.5.0
>
>         Attachments: RATIS-698.01.patch
>
>
> Followers always wait for (minTimeoutMillis + randomWait), before initiating leader election. This penalizes the first time the ratis ring is created or when server restarts by enforcing a wait for leader election term.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)