[GitHub] [ozone] umamaheswararao commented on a change in pull request #3085: HDDS-6307. Improve processing and memory efficiency of full container reports

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #3085:
URL: https://github.com/apache/ozone/pull/3085#discussion_r814969690



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java
##########
@@ -70,30 +70,49 @@
     this.logger = logger;
   }
 
+  /**
+   *

Review comment:
       You thought to add some description here and missed?

##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerInfo.java
##########
@@ -219,7 +226,6 @@ public void updateLastUsedTime() {
   public HddsProtos.ContainerInfoProto getProtobuf() {
     HddsProtos.ContainerInfoProto.Builder builder =
         HddsProtos.ContainerInfoProto.newBuilder();
-    Preconditions.checkState(containerID > 0);

Review comment:
       >=0 ? or just > should be suffice? I think id starts from 1 right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org