[jira] [Commented] (CB-12810) keep existing formatting in package.json

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238374#comment-16238374 ] 

ASF GitHub Bot commented on CB-12810:
-------------------------------------

audreyso opened a new pull request #606: CB-12810 : keep existing formatting in package.json and fix eslint errors
URL: https://github.com/apache/cordova-lib/pull/606
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   ### What does this PR do?
   Updated indenting for pkgJson
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [X] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> keep existing formatting in package.json
> ----------------------------------------
>
>                 Key: CB-12810
>                 URL: https://issues.apache.org/jira/browse/CB-12810
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-lib
>    Affects Versions: 7.0.0
>            Reporter: Steve Gill
>            Priority: Minor
>              Labels: backlog, cordova-8.0.0, cordova-next, tools-next
>
> We will write our own indentation in package.json. For commands that shell out to cordova-fetch and therefore npm, we have no control over it (cordova platform/plugin add/rm).
> We could theoretically keep indentaiton for commands where we write to package.json (also platform/plugin add/rm to cordova key & during restore when we sync config.xml & package.json).
> This issue is probably not worth implementing. 
> npm@5 seems like it will respect existing formatting. 
> Previous issue with npm formatting: https://github.com/npm/npm/issues/5694
> npm5 respecting indentation: https://github.com/npm/npm/issues/16244



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org