[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

[hhbyyh <gi...@git.apache.org>]

Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17673#discussion_r148967766
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala ---
    @@ -105,6 +106,56 @@ private[feature] trait Word2VecBase extends Params
       /** @group getParam */
       def getMaxSentenceLength: Int = $(maxSentenceLength)
     
    +  /**
    +   * Number of negative samples to use with CBOW based estimation.
    +   * This parameter is ignored for SkipGram-Hierachical Softmax based estimation.
    --- End diff --
    
    Rather than exclusion, I would recommend to use precise description here and in other places.
    The parameter is only used for continuous bag-of-words with negative sampling algorithm, i.e. solver = "cbow-ns".


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org