You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mahout.apache.org by "Suneel Marthi (JIRA)" <ji...@apache.org> on 2013/06/02 08:51:20 UTC

[jira] [Comment Edited] (MAHOUT-1211) Replace deprecated Closables.closeQuietly calls

    [ https://issues.apache.org/jira/browse/MAHOUT-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13672325#comment-13672325 ] 

Suneel Marthi edited comment on MAHOUT-1211 at 6/2/13 6:49 AM:
---------------------------------------------------------------

Working on this Ted, done with all of the classes except those that extend AbstractIterator (like- FileLineIterator, SequenceFileValueIterator, SequenceFileIterator, ARFFIterator etc.. I can look into those classes tomorrow morning.

Attached patch has changes for all of the classes except for those that extend AbstractIterator.  
                
      was (Author: smarthi):
    Working on this Ted, done with all of the classes except those that extend AbstractIterator (like- FileLineIterator, SequenceFileValueIterator, SequenceFileIterator, ARFFIterator etc.. I can look into those classes tomorrow morning.

Attached patch has changes for all of the others excepting for those classes extending AbstractIterator.  
                  
> Replace deprecated Closables.closeQuietly calls
> -----------------------------------------------
>
>                 Key: MAHOUT-1211
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1211
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: Stevo Slavic
>            Assignee: Ted Dunning
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: MAHOUT-1211.patch
>
>
> Deprecated Guava {{Closables.closeQuietly}} API has to be replaced, it's usage is a code smell, and that method is scheduled to be removed from Guava 16.0.
> See [this discussion|https://code.google.com/p/guava-libraries/issues/detail?id=1118] for more info.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira