You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by "jungm (via GitHub)" <gi...@apache.org> on 2023/10/13 11:45:21 UTC
[PR] Site updates [johnzon]
jungm opened a new pull request, #113:
URL: https://github.com/apache/johnzon/pull/113
Fixes a few things I noticed while looking at the current site like broken links, javadoc not generating anymore, outdated download links, etc
Also Updates the site for JSON-P 2.1/JSON-B 3.0, documents properties I added in #103 and the removal of johnzon-jsonp-strict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #113:
URL: https://github.com/apache/johnzon/pull/113#issuecomment-1838641909
@rmannibucau mvn central link is updated. Thanks for pointing out, actually didnt know repo1 is not supposed to be used :)
But: I can't find the geronimo spec jars for jsonp 2.1/jsonb 3.0
https://github.com/apache/geronimo-specs hasn't been touched since 2019, jakarta/eclipse foundation jars are also used in the [pom](https://github.com/apache/johnzon/blob/master/pom.xml#L75)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on code in PR #113:
URL: https://github.com/apache/johnzon/pull/113#discussion_r1358223869
##########
src/site/markdown/index.md:
##########
@@ -353,6 +355,8 @@ JsonbConfig specific properties:
* johnzon.accessMode: custom access mode, note that it can disable some JSON-B feature (annotations support).
* johnzon.accessModeDelegate: delegate access mode used by JsonbAccessModel. Enables to enrich default access mode.
* johnzon.failOnMissingCreatorValues: should the mapping fail when a `@JsonbCreator` misses some values.
+* johnzon.use-biginteger-stringadapter: Wether or not `BigInteger` is mapped as a string. `true` by default, set to `false` to ensure strict JSON-B 3 compliance
Review Comment:
nice catch! fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii merged PR #113:
URL: https://github.com/apache/johnzon/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #113:
URL: https://github.com/apache/johnzon/pull/113#issuecomment-1840474092
@jungm well this is true but we still have this default issue (https://github.com/jakartaee/jsonp-api/blob/master/api/src/main/java/jakarta/json/spi/JsonProvider.java#L78 for jsonp for ex) so ultimately it can mean we still need custom jars (thinking a bit out loud but relying on the SPI is likely not what we want in maven and OSGi). Maybe a note on that issue of the spec can make it less a surprise to end user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #113:
URL: https://github.com/apache/johnzon/pull/113#issuecomment-1847038747
@rmannibucau added a few sentences to give users a small heads up that parsson is indeed hardcoded in the API jar now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #113:
URL: https://github.com/apache/johnzon/pull/113#issuecomment-1838727582
@jungm i guess they use the jakarta classifier as of today. What is in the pom is fine while not transitive (the case today), now when you propose a public API it should probably be the least hurtful and some env will not respect properly the ServiceLoader mecanism so hardcoded default is generally better so while we can use it I think it does not hurt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #113:
URL: https://github.com/apache/johnzon/pull/113#issuecomment-1840337802
But isn't EE 8 relocated to `jakarta.*` basically EE9?
the EE9 API jars will probably work fine with johnzon 2.0.x, but that also means users can't use new jsonp 2.1 and jsonb 3.0 features
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Site updates [johnzon]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #113:
URL: https://github.com/apache/johnzon/pull/113#discussion_r1358218524
##########
src/site/markdown/index.md:
##########
@@ -353,6 +355,8 @@ JsonbConfig specific properties:
* johnzon.accessMode: custom access mode, note that it can disable some JSON-B feature (annotations support).
* johnzon.accessModeDelegate: delegate access mode used by JsonbAccessModel. Enables to enrich default access mode.
* johnzon.failOnMissingCreatorValues: should the mapping fail when a `@JsonbCreator` misses some values.
+* johnzon.use-biginteger-stringadapter: Wether or not `BigInteger` is mapped as a string. `true` by default, set to `false` to ensure strict JSON-B 3 compliance
Review Comment:
Wether => Whether ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org