[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #612: [FLINK-32272] Expose LOAD_MAX as autoscaler metric

["mxm (via GitHub)" <gi...@apache.org>]

mxm commented on code in PR #612:
URL: https://github.com/apache/flink-kubernetes-operator/pull/612#discussion_r1222753778


##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricEvaluator.java:
##########
@@ -137,6 +138,12 @@ private Map<ScalingMetric, EvaluatedScalingMetric> evaluateMetrics(
                         latestVertexMetrics.get(TRUE_PROCESSING_RATE),
                         getAverage(TRUE_PROCESSING_RATE, vertex, metricsHistory)));
 
+        evaluatedMetrics.put(
+                LOAD_MAX,

Review Comment:
   I would suggest exposing this as `LOAD` and let this work with both LOAD_MAX and LOAD_AVG scaling metric. The default is already to use LOAD_MAX.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org