You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Iamoshione (via GitHub)" <gi...@apache.org> on 2025/03/03 05:34:22 UTC
[PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Iamoshione opened a new pull request, #19077:
URL: https://github.com/apache/kafka/pull/19077
In the documentation today, we have the following sentence:
By default, if no ResourcePatterns match a specific Resource R, then R has no associated ACLs, and therefore no one other than super users is allowed to access R. If you want to change that behavior, you can include the following in server.properties.
Although, it is correct, I have observed users being confused by it. I think could me made clearer that default is deny and this property is a way to change default.
Change
Replace the above with the following:
Default Behavior Without ACLs:
If a resource (R) does not have any ACLs defined—that is, if no ACL matches the resource—Kafka will restrict access to that resource. In this situation, only super users are allowed to access it.
Changing the Default Behavior:
If you prefer that resources without any ACLs be accessible by all users (instead of just super users), you can change the default behavior. To do this, add the following line to your server.properties file:
allow.everyone.if.no.acl.found=true
With this setting enabled, if a resource does not have any ACLs defined, Kafka will allow access to everyone. If a resource has one or more ACLs defined, those ACL rules will be enforced as usual, regardless of the setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #19077:
URL: https://github.com/apache/kafka/pull/19077#discussion_r1981043279
##########
docs/security.html:
##########
@@ -1248,11 +1248,15 @@ <h3 class="anchor-heading"><a id="security_authz" class="anchor-link"></a><a hre
Kafka ACLs are defined in the general format of "Principal {P} is [Allowed|Denied] Operation {O} From Host {H} on any Resource {R} matching ResourcePattern {RP}".
You can read more about the ACL structure in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface">KIP-11</a> and
resource patterns in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-290%3A+Support+for+Prefixed+ACLs">KIP-290</a>.
- In order to add, remove, or list ACLs, you can use the Kafka ACL CLI <code>kafka-acls.sh</code>. By default, if no ResourcePatterns match a specific Resource R,
- then R has no associated ACLs, and therefore no one other than super users is allowed to access R.
- If you want to change that behavior, you can include the following in server.properties.
+ In order to add, remove, or list ACLs, you can use the Kafka ACL CLI <code>kafka-acls.sh</code>.
+ <h5>Default Behavior Without ACLs:</h5>
+ <p>If a resource (R) does not have any ACLs defined—that is, if no ACL matches the resource—Kafka will restrict access to that resource. In this situation, only super users are allowed to access it.
+ </p>
+ <h5>Changing the Default Behavior:</h5>
+ <p>If you prefer that resources without any ACLs be accessible by all users (instead of just super users), you can change the default behavior. To do this, add the following line to your server.properties file:</p>
<pre><code class="language-text">allow.everyone.if.no.acl.found=true</code></pre>
- One can also add super users in server.properties like the following (note that the delimiter is semicolon since SSL user names may contain comma). Default PrincipalType string "User" is case sensitive.
+ With this setting enabled, if a resource does not have any ACLs defined, Kafka will allow access to everyone. If a resource has one or more ACLs defined, those ACL rules will be enforced as usual, regardless of the setting.
Review Comment:
nit: The use of `<p>` and `</p>` around the preformatted blocks is not entirely consistent.
##########
docs/security.html:
##########
@@ -1248,11 +1248,15 @@ <h3 class="anchor-heading"><a id="security_authz" class="anchor-link"></a><a hre
Kafka ACLs are defined in the general format of "Principal {P} is [Allowed|Denied] Operation {O} From Host {H} on any Resource {R} matching ResourcePattern {RP}".
You can read more about the ACL structure in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface">KIP-11</a> and
resource patterns in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-290%3A+Support+for+Prefixed+ACLs">KIP-290</a>.
- In order to add, remove, or list ACLs, you can use the Kafka ACL CLI <code>kafka-acls.sh</code>. By default, if no ResourcePatterns match a specific Resource R,
- then R has no associated ACLs, and therefore no one other than super users is allowed to access R.
- If you want to change that behavior, you can include the following in server.properties.
+ In order to add, remove, or list ACLs, you can use the Kafka ACL CLI <code>kafka-acls.sh</code>.
+ <h5>Default Behavior Without ACLs:</h5>
+ <p>If a resource (R) does not have any ACLs defined—that is, if no ACL matches the resource—Kafka will restrict access to that resource. In this situation, only super users are allowed to access it.
Review Comment:
nit: `defined-that` and `resource-Kafka` look like hyphenated words. You perhaps want `—` instead of `-`, so `resource — Kafka`. Personally, I would rewrite like this:
`If a resource (R) does not have any ACLs defined, meaning that no ACL matches the resource, Kafka will restrict`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #19077:
URL: https://github.com/apache/kafka/pull/19077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #19077:
URL: https://github.com/apache/kafka/pull/19077#discussion_r1981867953
##########
docs/security.html:
##########
@@ -1248,11 +1248,16 @@ <h3 class="anchor-heading"><a id="security_authz" class="anchor-link"></a><a hre
Kafka ACLs are defined in the general format of "Principal {P} is [Allowed|Denied] Operation {O} From Host {H} on any Resource {R} matching ResourcePattern {RP}".
You can read more about the ACL structure in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface">KIP-11</a> and
resource patterns in <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-290%3A+Support+for+Prefixed+ACLs">KIP-290</a>.
- In order to add, remove, or list ACLs, you can use the Kafka ACL CLI <code>kafka-acls.sh</code>. By default, if no ResourcePatterns match a specific Resource R,
- then R has no associated ACLs, and therefore no one other than super users is allowed to access R.
- If you want to change that behavior, you can include the following in server.properties.
+ In order to add, remove, or list ACLs, you can use the Kafka ACL CLI <code>kafka-acls.sh</code>.
+ <h5><u>Behavior Without ACLs:</u> </h5>
+ <p>If a resource (R) does not have any ACLs defined, meaning that no ACL matches the resource, Kafka will restrict access to that resource. In this situation, only super users are allowed to access it.
Review Comment:
nit: Indentation is slightly off.
##########
docs/security.html:
##########
@@ -2366,4 +2371,4 @@ <h3 class="anchor-heading"><a id="security_rolling_upgrade" class="anchor-link">
security.inter.broker.protocol=SSL</code></pre>
</script>
-<div class="p-security"></div>
+<div class="p-security"></div>
Review Comment:
This doesn't seem like a necessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2693435237
@frankvicky
Thanks! I've attached the screenshot showing how the changes look in the browser. Let me know if you need any adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2701402395

Hey @AndrewJSchofield , thank you for acknowledging my PR. I have reviewed your requested changes and made the necessary updates accordingly. Additionally, I added an underline tag to maintain consistency throughout the document. Let me know if you need any further changes. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione closed pull request #19077: KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer
URL: https://github.com/apache/kafka/pull/19077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2701858209
@AndrewJSchofield Hello there I have adjusted the indentation and removed the unnecessary div tag at the end of the page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2693445728

@frankvicky
Thanks! Here’s the screenshot of the rendered changes. Let me know if everything looks good or if you’d like any modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702105935
@AndrewJSchofield Apologies for the oversight—I didn’t notice it on time. I’ve now addressed the request as specified. Let me know if any further changes are needed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702116652
@AndrewJSchofield Branch updated with trunk. Please let me know if any further changes are needed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "Iamoshione (via GitHub)" <gi...@apache.org>.
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2693432880

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702110906
@Iamoshione Please could you update the branch with the latest changes from trunk. I will need a green build of up-to-date code to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18766:Docs: Make usage of allow.everyone.if.no.acl.found config clearer [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #19077:
URL: https://github.com/apache/kafka/pull/19077#discussion_r1982140648
##########
docs/security.html:
##########
@@ -2366,4 +2374,4 @@ <h3 class="anchor-heading"><a id="security_rolling_upgrade" class="anchor-link">
security.inter.broker.protocol=SSL</code></pre>
</script>
-<div class="p-security"></div>
Review Comment:
I still do not see why this PR contains this final change. The changes should all be in the ACL section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org