You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/07 19:48:00 UTC

[jira] [Work logged] (HADOOP-18088) Replace log4j 1.x with reload4j

     [ https://issues.apache.org/jira/browse/HADOOP-18088?focusedWorklogId=767594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767594 ]

ASF GitHub Bot logged work on HADOOP-18088:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/May/22 19:47
            Start Date: 07/May/22 19:47
    Worklog Time Spent: 10m 
      Work Description: ayushtkn commented on code in PR #4052:
URL: https://github.com/apache/hadoop/pull/4052#discussion_r867388481


##########
hadoop-project/pom.xml:
##########
@@ -1626,13 +1688,45 @@
         <groupId>org.apache.hbase</groupId>
         <artifactId>hbase-server</artifactId>
         <version>${hbase.version}</version>
+        <exclusions>
+          <exclusion>
+            <groupId>log4j</groupId>
+            <artifactId>log4j</artifactId>
+          </exclusion>
+        </exclusions>
+      </dependency>
+      <dependency>
+        <groupId>org.apache.hbase</groupId>
+        <artifactId>hbase-server</artifactId>
+        <version>${hbase.version}</version>
+        <scope>test</scope>

Review Comment:
   @iwasakims hbase-server was already there, with compile scope, why was it added here again with test scope?
   It seems to give warnings while building 3.3.3 to me
   ```
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model for org.apache.hadoop:hadoop-project:pom:3.3.3
   [WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.hbase:hbase-server:jar -> duplicate declaration of version ${hbase.version} @ line 1691, column 19
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 767594)
    Time Spent: 7h 40m  (was: 7.5h)

> Replace log4j 1.x with reload4j
> -------------------------------
>
>                 Key: HADOOP-18088
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18088
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.10.2, 3.2.4, 3.3.3
>
>          Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> As proposed in the dev mailing list (https://lists.apache.org/thread/fdzkv80mzkf3w74z9120l0k0rc3v7kqk) let's replace log4j 1 with reload4j in the maintenance releases (i.e. 3.3.x, 3.2.x and 2.10.x)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org