You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sadhen <gi...@git.apache.org> on 2018/09/01 15:51:40 UTC
[GitHub] spark pull request #22310: [Spark-25298][Build] Improve build definition for...
GitHub user sadhen opened a pull request:
https://github.com/apache/spark/pull/22310
[Spark-25298][Build] Improve build definition for Scala 2.12
## What changes were proposed in this pull request?
Improve build for Scala 2.12.
## How was this patch tested?
```
./dev/change-scala-version.sh 2.12
## For Maven
./build/mvn -Pscala-2.12 [mvn commands]
## For SBT
sbt -Dscala.version=2.12.6
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sadhen/spark SPARK-25298
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22310
----
commit 080df1328c0665c6f1d72a9b956d0013e5811127
Author: Darcy Shen <sa...@...>
Date: 2018-09-01T15:18:23Z
attempt to improve build
commit 7f1b3f40e50ca60aa7efaf6f731f96d896ed871b
Author: Darcy Shen <sa...@...>
Date: 2018-09-01T15:25:13Z
tuning for maven
commit 7c0b9b955b34f19e337619c369bf7c468b7654e1
Author: Darcy Shen <sa...@...>
Date: 2018-09-01T15:46:47Z
more docs for scala 2.12
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22310: [Spark-25298][Build] Improve build definition for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22310
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22310
Why the move of the source code in the 2.11 tree? looks like it's not in the right package dir now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by sadhen <gi...@git.apache.org>.
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22310
@srowen It is about the sbt convention.
see my demo project: https://github.com/sadhen/spark-25298
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22310
**[Test build #95579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95579/testReport)** for PR 22310 at commit [`7c0b9b9`](https://github.com/apache/spark/commit/7c0b9b955b34f19e337619c369bf7c468b7654e1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22310
@sadhen we use Maven though, not SBT. (SBT works through a plugin). But my point is the path `.../repl/...` which doesn't reflect the class's path. Scala and Java convention has always put code in a source tree according to its package. This also already works right now. I'm confused why you say this needs to change, and think it should simply be reverted.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22310
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22310
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22310
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22310
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22310
**[Test build #95579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95579/testReport)** for PR 22310 at commit [`7c0b9b9`](https://github.com/apache/spark/commit/7c0b9b955b34f19e337619c369bf7c468b7654e1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22310
**[Test build #95595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95595/testReport)** for PR 22310 at commit [`77edff4`](https://github.com/apache/spark/commit/77edff4b8d3a2a2a32d7b4ba7d7cc9c8175ea231).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by sadhen <gi...@git.apache.org>.
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22310
The problem of package hierarchy is fixed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22310
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22310
**[Test build #95595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95595/testReport)** for PR 22310 at commit [`77edff4`](https://github.com/apache/spark/commit/77edff4b8d3a2a2a32d7b4ba7d7cc9c8175ea231).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by sadhen <gi...@git.apache.org>.
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22310
@srowen Sorry I should have explained why I made these changes.
The follow steps failed to compile:
```
$ ./dev/change-scala-version.sh 2.12
$ ./build/sbt -Dscala-2.12 -Dscala.version=2.12.6
> project repl
> compile
```
After these changes, the commands are simplified and the compile works:
```
$ ./dev/change-scala-version.sh 2.12
$ ./build/sbt -Dscala.version=2.12.6
> project repl
> compile
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95595/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95579/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22310: [Spark-25298][Build] Improve build definition for Scala ...
Posted by sadhen <gi...@git.apache.org>.
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22310
@srowen This is a better solution for #22280
No hard-coded 2.11 or 2.12 any more.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org