You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Myracle (via GitHub)" <gi...@apache.org> on 2026/02/11 02:43:13 UTC
[PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Myracle opened a new pull request, #27576:
URL: https://github.com/apache/flink/pull/27576
## What is the purpose of the change
This pull request adds HTTP Basic Authentication support for the PrometheusPushGatewayReporter. This enables users to connect Flink metrics reporting to secured PushGateway instances that require authentication.
Many production deployments secure their PushGateway endpoints with authentication to prevent unauthorized metrics submission. Without this feature, users would need to configure network-level security (firewalls, VPNs) to protect the PushGateway, which is often more complex and less flexible than application-level authentication.
## Brief change log
- Added `username` and `password` configuration options to `PrometheusPushGatewayReporterOptions` for specifying HTTP Basic Auth credentials
- Updated `PrometheusPushGatewayReporter` to configure `BasicAuthHttpConnectionFactory` when both credentials are provided
- Updated `PrometheusPushGatewayReporterFactory` to read credentials from configuration and emit a warning log when only one of username/password is configured (incomplete configuration)
- Added unit tests to cover all authentication scenarios (no auth, partial auth with warning, complete auth)
- Updated documentation (both English and Chinese) with configuration examples and security recommendations
## Verifying this change
This change added tests and can be verified as follows:
- Added `PrometheusPushGatewayReporterTest#testBasicAuthNotEnabledWithoutCredentials` - verifies reporter creation without credentials
- Added `PrometheusPushGatewayReporterTest#testBasicAuthNotEnabledWithOnlyUsername` - verifies warning log when only username is configured
- Added `PrometheusPushGatewayReporterTest#testBasicAuthNotEnabledWithOnlyPassword` - verifies warning log when only password is configured
- Added `PrometheusPushGatewayReporterTest#testBasicAuthEnabledWithBothCredentials` - verifies reporter creation with complete credentials
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no** (uses existing `simpleclient_pushgateway` dependency which already includes `BasicAuthHttpConnectionFactory`)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes** (added new configuration options `username` and `password` to `PrometheusPushGatewayReporterOptions` which is annotated with `@PublicEvolving`)
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **yes**
- If yes, how is the feature documented? **docs** (updated `docs/content/docs/deployment/metric_reporters.md` and `docs/content.zh/docs/deployment/metric_reporters.md`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "rionmonster (via GitHub)" <gi...@apache.org>.
rionmonster commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2791264594
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterFactory.java:
##########
@@ -70,17 +72,28 @@ public PrometheusPushGatewayReporter createMetricReporter(Properties properties)
jobName = configuredJobName + new AbstractID();
}
+ String username = metricConfig.getString(USERNAME.key(), null);
Review Comment:
Minor consistency nit: for consistency, we may want to use `defaultValue()` instead of `null` here as those would both functionally identical (null) but would follow the same pattern as the other available configuration options.
For example, `HOST_URL`:
```
String hostUrl = metricConfig.getString(HOST_URL.key(), HOST_URL.defaultValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "Myracle (via GitHub)" <gi...@apache.org>.
Myracle commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2797271869
##########
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterTest.java:
##########
@@ -68,4 +77,62 @@ void testConnectToPushGatewayThrowsExceptionWithoutHostInformation() {
assertThatThrownBy(() -> factory.createMetricReporter(metricConfig))
.isInstanceOf(IllegalArgumentException.class);
}
+
+ @Test
+ void testBasicAuthNotEnabledWithoutCredentials() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ // No authentication configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ assertThat(reporter.hostUrl.toString()).isEqualTo("http://localhost:9091");
+ }
+
+ @Test
+ void testBasicAuthNotEnabledWithOnlyUsername() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(USERNAME.key(), "flink-user");
+ // Only username configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ // Verify warning log is emitted
+ assertThat(loggerExtension.getMessages())
+ .anyMatch(
+ msg ->
+ msg.contains("Both username and password must be configured")
+ && msg.contains("Currently only username is configured"));
+ }
+
+ @Test
+ void testBasicAuthNotEnabledWithOnlyPassword() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(PASSWORD.key(), "flink-password");
+ // Only password configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ // Verify warning log is emitted
+ assertThat(loggerExtension.getMessages())
+ .anyMatch(
+ msg ->
+ msg.contains("Both username and password must be configured")
+ && msg.contains("Currently only password is configured"));
+ }
+
+ @Test
+ void testBasicAuthEnabledWithBothCredentials() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(USERNAME.key(), "flink-user");
+ metricConfig.setProperty(PASSWORD.key(), "flink-password");
+ // Both username and password configured - Basic Auth should be enabled
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
Review Comment:
Thanks for the suggestion! I've added a @VisibleForTesting boolean basicAuthEnabled field following the same pattern as hostUrl. Now all four basic auth test cases verify this property:
testBasicAuthNotEnabledWithoutCredentials - asserts basicAuthEnabled is false
testBasicAuthNotEnabledWithOnlyUsername - asserts basicAuthEnabled is false
testBasicAuthNotEnabledWithOnlyPassword - asserts basicAuthEnabled is false
testBasicAuthEnabledWithBothCredentials - asserts basicAuthEnabled is true
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterFactory.java:
##########
@@ -70,17 +72,28 @@ public PrometheusPushGatewayReporter createMetricReporter(Properties properties)
jobName = configuredJobName + new AbstractID();
}
+ String username = metricConfig.getString(USERNAME.key(), null);
Review Comment:
Thanks for catching this! You're absolutely right - I've updated the code to use USERNAME.defaultValue() and PASSWORD.defaultValue() instead of hardcoded null to maintain consistency with other configuration options like HOST_URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "rionmonster (via GitHub)" <gi...@apache.org>.
rionmonster commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2791300264
##########
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterTest.java:
##########
@@ -68,4 +77,62 @@ void testConnectToPushGatewayThrowsExceptionWithoutHostInformation() {
assertThatThrownBy(() -> factory.createMetricReporter(metricConfig))
.isInstanceOf(IllegalArgumentException.class);
}
+
+ @Test
+ void testBasicAuthNotEnabledWithoutCredentials() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ // No authentication configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ assertThat(reporter.hostUrl.toString()).isEqualTo("http://localhost:9091");
+ }
+
+ @Test
+ void testBasicAuthNotEnabledWithOnlyUsername() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(USERNAME.key(), "flink-user");
+ // Only username configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ // Verify warning log is emitted
+ assertThat(loggerExtension.getMessages())
+ .anyMatch(
+ msg ->
+ msg.contains("Both username and password must be configured")
+ && msg.contains("Currently only username is configured"));
+ }
+
+ @Test
+ void testBasicAuthNotEnabledWithOnlyPassword() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(PASSWORD.key(), "flink-password");
+ // Only password configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ // Verify warning log is emitted
+ assertThat(loggerExtension.getMessages())
+ .anyMatch(
+ msg ->
+ msg.contains("Both username and password must be configured")
+ && msg.contains("Currently only password is configured"));
+ }
+
+ @Test
+ void testBasicAuthEnabledWithBothCredentials() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(USERNAME.key(), "flink-user");
+ metricConfig.setProperty(PASSWORD.key(), "flink-password");
+ // Both username and password configured - Basic Auth should be enabled
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
Review Comment:
I think we need to add another assertion to this test to verify that authentication _was_ actually enabled. We may want to consider following a pattern similar to `hostUrl` to expose it for testing (e.g. @VisibleForTesting package-private boolean field), something like `basicAuthEnabled` and then we could simply check that property here:
```
assertThat(reporter.basicAuthEnabled).isTrue();
```
Either that or rely on a reflection based approach to inspect the underlying connection factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.
JunRuiLee merged PR #27576:
URL: https://github.com/apache/flink/pull/27576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27576:
URL: https://github.com/apache/flink/pull/27576#issuecomment-3881832980
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0721847b6a7a10b7e583561d241c7b70b7de56af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0721847b6a7a10b7e583561d241c7b70b7de56af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0721847b6a7a10b7e583561d241c7b70b7de56af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "Myracle (via GitHub)" <gi...@apache.org>.
Myracle commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2801850917
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterFactory.java:
##########
@@ -70,17 +72,28 @@ public PrometheusPushGatewayReporter createMetricReporter(Properties properties)
jobName = configuredJobName + new AbstractID();
}
+ String username = metricConfig.getString(USERNAME.key(), USERNAME.defaultValue());
+ String password = metricConfig.getString(PASSWORD.key(), PASSWORD.defaultValue());
+
+ if ((username != null && password == null) || (username == null && password != null)) {
+ LOG.warn(
+ "Both username and password must be configured to enable HTTP Basic Authentication. "
+ + "Currently only {} is configured, Basic Auth will be disabled.",
+ username != null ? "username" : "password");
+ }
+
LOG.info(
- "Configured PrometheusPushGatewayReporter with {hostUrl:{}, jobName:{}, randomJobNameSuffix:{}, deleteOnShutdown:{}, groupingKey:{}}",
+ "Configured PrometheusPushGatewayReporter with {hostUrl:{}, jobName:{}, randomJobNameSuffix:{}, deleteOnShutdown:{}, groupingKey:{}, basicAuth:{}}",
hostUrl,
jobName,
randomSuffix,
deleteOnShutdown,
- groupingKey);
+ groupingKey,
+ username != null && password != null);
Review Comment:
Good catch! I've refactored the code to use reporter.basicAuthEnabled instead of duplicating the username != null && password != null logic. Now the log statement references the field directly from the created reporter, ensuring consistency and eliminating redundancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "rionmonster (via GitHub)" <gi...@apache.org>.
rionmonster commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2791300264
##########
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterTest.java:
##########
@@ -68,4 +77,62 @@ void testConnectToPushGatewayThrowsExceptionWithoutHostInformation() {
assertThatThrownBy(() -> factory.createMetricReporter(metricConfig))
.isInstanceOf(IllegalArgumentException.class);
}
+
+ @Test
+ void testBasicAuthNotEnabledWithoutCredentials() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ // No authentication configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ assertThat(reporter.hostUrl.toString()).isEqualTo("http://localhost:9091");
+ }
+
+ @Test
+ void testBasicAuthNotEnabledWithOnlyUsername() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(USERNAME.key(), "flink-user");
+ // Only username configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ // Verify warning log is emitted
+ assertThat(loggerExtension.getMessages())
+ .anyMatch(
+ msg ->
+ msg.contains("Both username and password must be configured")
+ && msg.contains("Currently only username is configured"));
+ }
+
+ @Test
+ void testBasicAuthNotEnabledWithOnlyPassword() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(PASSWORD.key(), "flink-password");
+ // Only password configured - should create reporter successfully without Basic Auth
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
+ assertThat(reporter).isNotNull();
+ // Verify warning log is emitted
+ assertThat(loggerExtension.getMessages())
+ .anyMatch(
+ msg ->
+ msg.contains("Both username and password must be configured")
+ && msg.contains("Currently only password is configured"));
+ }
+
+ @Test
+ void testBasicAuthEnabledWithBothCredentials() {
+ PrometheusPushGatewayReporterFactory factory = new PrometheusPushGatewayReporterFactory();
+ MetricConfig metricConfig = new MetricConfig();
+ metricConfig.setProperty(HOST_URL.key(), "http://localhost:9091");
+ metricConfig.setProperty(USERNAME.key(), "flink-user");
+ metricConfig.setProperty(PASSWORD.key(), "flink-password");
+ // Both username and password configured - Basic Auth should be enabled
+ PrometheusPushGatewayReporter reporter = factory.createMetricReporter(metricConfig);
Review Comment:
I think we need to add another assertion to this test to verify that authentication _was_ actually enabled. We may want to consider following a pattern similar to `hostUrl` to expose it for testing (e.g. @VisibleForTesting package-private boolean field), something like `basicAuthEnabled` and then we could simply check that property here:
```
assertThat(reporter.basicAuthEnabled).isTrue();
```
Either that or rely on a reflection based approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "rionmonster (via GitHub)" <gi...@apache.org>.
rionmonster commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2800072208
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterFactory.java:
##########
@@ -70,17 +72,28 @@ public PrometheusPushGatewayReporter createMetricReporter(Properties properties)
jobName = configuredJobName + new AbstractID();
}
+ String username = metricConfig.getString(USERNAME.key(), USERNAME.defaultValue());
+ String password = metricConfig.getString(PASSWORD.key(), PASSWORD.defaultValue());
+
+ if ((username != null && password == null) || (username == null && password != null)) {
+ LOG.warn(
+ "Both username and password must be configured to enable HTTP Basic Authentication. "
+ + "Currently only {} is configured, Basic Auth will be disabled.",
+ username != null ? "username" : "password");
+ }
+
LOG.info(
- "Configured PrometheusPushGatewayReporter with {hostUrl:{}, jobName:{}, randomJobNameSuffix:{}, deleteOnShutdown:{}, groupingKey:{}}",
+ "Configured PrometheusPushGatewayReporter with {hostUrl:{}, jobName:{}, randomJobNameSuffix:{}, deleteOnShutdown:{}, groupingKey:{}, basicAuth:{}}",
hostUrl,
jobName,
randomSuffix,
deleteOnShutdown,
- groupingKey);
+ groupingKey,
+ username != null && password != null);
Review Comment:
Minor nit: this can probably align with the recently added `basicAuthEnabled` flag to avoid the redundant logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "Varka808 (via GitHub)" <gi...@apache.org>.
Varka808 commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2870185780
##########
docs/layouts/shortcodes/generated/python_configuration.html:
##########
Review Comment:
This part seems to be an irrelevant modification.
##########
docs/layouts/shortcodes/generated/python_configuration.html:
##########
@@ -68,6 +62,12 @@
<td>Boolean</td>
<td>If set, the Python worker will configure itself to use the managed memory budget of the task slot. Otherwise, it will use the Off-Heap Memory of the task slot. In this case, users should set the Task Off-Heap Memory using the configuration key taskmanager.memory.task.off-heap.size.</td>
</tr>
+ <tr>
Review Comment:
This part seems to be an irrelevant modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-27661][Runtime / Metrics] PrometheusPushGatewayReporter support pushgateway http authentication [flink]
Posted by "Varka808 (via GitHub)" <gi...@apache.org>.
Varka808 commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2870183239
##########
docs/layouts/shortcodes/generated/python_configuration.html:
##########
@@ -68,6 +62,12 @@
<td>Boolean</td>
<td>If set, the Python worker will configure itself to use the managed memory budget of the task slot. Otherwise, it will use the Off-Heap Memory of the task slot. In this case, users should set the Task Off-Heap Memory using the configuration key taskmanager.memory.task.off-heap.size.</td>
</tr>
+ <tr>
Review Comment:
This part seems to be an irrelevant modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org