You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2016/12/29 17:02:52 UTC
[GitHub] drill pull request #714: DRILL-4919: Fix select count(1) / count(*) on csv w...
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/714
DRILL-4919: Fix select count(1) / count(*) on csv with header
When columns from file are not needed in result (`isSkipQuery = true`), empty list of columns is replaced for text files with `columns[0]`. But currently text files with headers do not support `columns` syntax, so for these type of files we need to replace empty list of columns with default named column.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-4919
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #714
----
commit c2d1e222fac64dc6c5b177c983a2e5b2d5227190
Author: Arina Ielchiieva <ar...@gmail.com>
Date: 2016-12-29T15:42:53Z
DRILL-4919: Fix select count(1) / count(*) on csv with header
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #714: DRILL-4919: Fix select count(1) / count(*) on csv with hea...
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/714
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #714: DRILL-4919: Fix select count(1) / count(*) on csv with hea...
Posted by gparai <gi...@git.apache.org>.
Github user gparai commented on the issue:
https://github.com/apache/drill/pull/714
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #714: DRILL-4919: Fix select count(1) / count(*) on csv w...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/714#discussion_r95770127
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java ---
@@ -91,6 +96,9 @@ public boolean apply(@Nullable SchemaPath path) {
@Override
protected List<SchemaPath> getDefaultColumnsToRead() {
+ if (settings.isHeaderExtractionEnabled()) {
--- End diff --
Added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #714: DRILL-4919: Fix select count(1) / count(*) on csv w...
Posted by gparai <gi...@git.apache.org>.
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/714#discussion_r95721099
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java ---
@@ -91,6 +96,9 @@ public boolean apply(@Nullable SchemaPath path) {
@Override
protected List<SchemaPath> getDefaultColumnsToRead() {
+ if (settings.isHeaderExtractionEnabled()) {
--- End diff --
Please add a comment describing the change - something similar to your comment
> ... currently text files with headers do not support columns syntax, so for these type of files we need to replace empty list of columns with default named column when header extraction is enabled
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #714: DRILL-4919: Fix select count(1) / count(*) on csv w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---