[GitHub] [orc] hinxx commented on a diff in pull request #1455: ORC-1401: [C++] allow writing an intermediate footer

["hinxx (via GitHub)" <gi...@apache.org>]

hinxx commented on code in PR #1455:
URL: https://github.com/apache/orc/pull/1455#discussion_r1162782666


##########
c++/src/Writer.cc:
##########
@@ -400,6 +405,24 @@ namespace orc {
     outStream->close();
   }
 
+  long WriterImpl::writeIntermediateFooter() {
+    if (stripeRows > 0) {
+      writeStripe();
+    }
+    if (stripesAtLastFlush != fileFooter.stripes_size()) {
+      writeMetadata();
+      writeFileFooter();
+      stripesAtLastFlush = fileFooter.stripes_size();
+      writePostscript();

Review Comment:
   I guess so since `fileFooter` is not touched in `writePostscript()`. Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org