You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "frankgh (via GitHub)" <gi...@apache.org> on 2025/06/25 11:59:18 UTC
[PR] CASSANALYTICS-73: Simplify SidecarTableSizeProvider [cassandra-analytics]
frankgh opened a new pull request, #126:
URL: https://github.com/apache/cassandra-analytics/pull/126
Patch by Francisco Guerrero; reviewed by TBD for CASSANALYTICS-73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-73: Simplify SidecarTableSizeProvider [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #126:
URL: https://github.com/apache/cassandra-analytics/pull/126#discussion_r2198839441
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/SizingFactory.java:
##########
@@ -91,9 +90,9 @@ else if (options.sizing() == null || options.sizing().isEmpty() || SIZING_DEFAUL
}
protected static TableSizeProvider getTableSizeProvider(SidecarClient sidecarClient,
Review Comment:
This makes sense. I think there are some opportunities to decouple Sidecar from the implementation and we should probably aim for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-73: Simplify SidecarTableSizeProvider [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh merged PR #126:
URL: https://github.com/apache/cassandra-analytics/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-73: Simplify SidecarTableSizeProvider [cassandra-analytics]
Posted by "liucao-dd (via GitHub)" <gi...@apache.org>.
liucao-dd commented on code in PR #126:
URL: https://github.com/apache/cassandra-analytics/pull/126#discussion_r2240614840
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/SizingFactory.java:
##########
@@ -91,9 +90,9 @@ else if (options.sizing() == null || options.sizing().isEmpty() || SIZING_DEFAUL
}
protected static TableSizeProvider getTableSizeProvider(SidecarClient sidecarClient,
Review Comment:
Separately - thoughts on making `maxPartitionSize` accept float (instead of only integer) such that we can allow 0.5GB or 256MB partition size? in my testing 1GB was too big for spark to handle per partition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org