You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/10/08 08:20:27 UTC
[PR] refactor(frontend): remove unused dictionary URL constants [texera]
aglinxinyuan opened a new pull request, #8922:
URL: https://github.com/apache/texera/pull/8922
### What changes were proposed in this PR?
Removes two module-level constants from `operator-metadata.service.ts` that nothing reads: `addDictionaryAPIAddress` and `getDictionaryAPIAddress`. **−3 lines.** There is no behaviour change. The constants aren't exported, their URL strings (`/api/resources/dictionary/`, `/api/upload/dictionary/`) appear nowhere else, and the backend has no route at either path. `OPERATOR_METADATA_ENDPOINT`, which the service does use, stays.
### History
| | |
| --- | --- |
| **Introduced by** | #696 (merged 2019-06-07), "Add saved project and dictionary upload components in user panel" |
| **Usage removed by** | **never used**. No line has ever read either constant. Later removals of similar dictionary URLs (e.g. in `user-dictionary.service.ts`) were different constants |
They have been unused for over six years.
### Any related issues, documentation, discussions?
Closes #8921
### How was this PR tested?
No new tests; nothing referenced the constants.
From `frontend/`:
- `npx ng test --watch=false`, covering `operator-metadata.service.spec.ts` plus the 40 other jsdom specs that import the service: 1846 tests pass, 1 is skipped (an existing `it.skip`).
- `npx ng run gui:test-browser --watch=false --include='**/code-editor.component.browser.spec.ts'` (the one browser spec that imports it): 11 tests, all pass.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n -e DictionaryAPIAddress -e "resources/dictionary" -e "upload/dictionary" # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused dictionary URL constants [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8922:
URL: https://github.com/apache/texera/pull/8922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused dictionary URL constants [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8922:
URL: https://github.com/apache/texera/pull/8922#issuecomment-6056659025
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove unused dictionary URL constants [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8922:
URL: https://github.com/apache/texera/pull/8922#issuecomment-6058127716
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8922?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.59%. Comparing base ([`535b97a`](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e78e3e7`](https://app.codecov.io/gh/apache/texera/commit/e78e3e70fbe8288f53528c9592fbb9c007d270b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8922 +/- ##
=========================================
Coverage 92.59% 92.59%
Complexity 5040 5040
=========================================
Files 1252 1252
Lines 53587 53587
Branches 6673 6673
=========================================
+ Hits 49619 49620 +1
Misses 2317 2317
+ Partials 1651 1650 -1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.07% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.48% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.59% <ø> (+<0.01%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.58% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [535b97a](https://app.codecov.io/gh/apache/texera/commit/535b97a941131cb0ac3a57f112b4e4c60f059d7e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8922?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org