[GitHub] [pulsar] codelipenghui commented on a change in pull request #14974: [Fix][Transaction] Fix transaction pendingAckStore asyncMarkDelete

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #14974:
URL: https://github.com/apache/pulsar/pull/14974#discussion_r840975527



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java
##########
@@ -898,4 +899,74 @@ public void testAutoCreateSchemaForTransactionSnapshot() throws Exception {
         pulsarServiceList.forEach((pulsarService ->
                 pulsarService.getConfiguration().setAllowAutoUpdateSchemaEnabled(true)));
     }
+
+    @Test
+    public void testPendingAckMarkDeletePosition() throws Exception {
+        String topic = NAMESPACE1 + "/test1";
+        Producer<byte[]> producer = pulsarClient
+                .newProducer(Schema.BYTES)
+                .topic(topic)
+                .sendTimeout(0, TimeUnit.SECONDS)
+                .create();
+
+        Consumer<byte[]> consumer = pulsarClient
+                .newConsumer()
+                .topic(topic)
+                .subscriptionName("sub")
+                .subscribe();
+        consumer.getSubscription();

Review comment:
       The producer and consumer should close after the test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org