You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gert Vanthienen (JIRA)" <de...@myfaces.apache.org> on 2006/04/14 11:15:00 UTC
[jira] Created: (MYFACES-1284) Generating component source code
Generating component source code
--------------------------------
Key: MYFACES-1284
URL: http://issues.apache.org/jira/browse/MYFACES-1284
Project: MyFaces Core
Type: Improvement
Components: build process
Reporter: Gert Vanthienen
Priority: Minor
The component code generator has been re-added to the Myfaces build process by Manfred Geiler, but there is still some work to be done. For a description, see also http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (MYFACES-1284) Generating component source
code
Posted by Zdeněk Sochor <zd...@ataco.cz>.
Hi,
i know of the change, but my patch would be used as middle-step, because
in current form, files of Tomhawk's components in SVN would be changed
considerably (and many important changes lost) due to plain regenerating.
Later i could move to the new generator, but it would require consistent
files anyway.
Zdenek
Andreas Berger napsal(a):
> Hi Zdenek,
>
> please keep in mind, that we adjusted the generator of Trinidad to
> work with the 1.2 branch of myfaces. In my opinion it's a better idea
> to work on only one generator, so maintaining the xmls is quite
> easier.
>
> cheers Andreas
>
> 2006/12/8, Zdenek Sochor (JIRA) <de...@myfaces.apache.org>:
>
>> [
>> http://issues.apache.org/jira/browse/MYFACES-1284?page=comments#action_12456745
>> ]
>>
>> Zdenek Sochor commented on MYFACES-1284:
>> ----------------------------------------
>>
>> If interested i can provide patch to re-enabling code generation for
>> Tomahawk components (at least for components marked with XML file).
>>
>> I altered generator patch to be able to process more conditions (like
>> supressing generation of setter for property).
>>
>> I have refactored all components using generation to be consistent
>> with SVN repository (altered files in generation part of files) - i
>> used version of files as of 6/12/2006, but i will update changes in
>> files to current versions prior to making patch.
>>
>> If used, i will expand auto-generation to allow generating of tags
>> and tld.
>> Also i can refactor all remaining components, which currently don't
>> use auto-generation XML file.
>>
>> In patch i also added support for using selection mode of user roles
>> (TOMAHAWK-489).
>>
>> Zdenek Sochor
>>
>> > Generating component source code
>> > --------------------------------
>> >
>> > Key: MYFACES-1284
>> > URL: http://issues.apache.org/jira/browse/MYFACES-1284
>> > Project: MyFaces Core
>> > Issue Type: Improvement
>> > Components: build process
>> > Reporter: Gert Vanthienen
>> > Assigned To: Matthias Weßendorf
>> > Priority: Minor
>> > Attachments: build-tools-generator.patch,
>> core-generator.patch, tomahawk-generator.patch
>> >
>> >
>> > The component code generator has been re-added to the Myfaces build
>> process by Manfred Geiler, but there is still some work to be done.
>> For a description, see also
>> http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators: http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>>
>>
>>
>
>
Re: [jira] Commented: (MYFACES-1284) Generating component source code
Posted by Andreas Berger <an...@googlemail.com>.
Hi Zdenek,
please keep in mind, that we adjusted the generator of Trinidad to
work with the 1.2 branch of myfaces. In my opinion it's a better idea
to work on only one generator, so maintaining the xmls is quite
easier.
cheers Andreas
2006/12/8, Zdenek Sochor (JIRA) <de...@myfaces.apache.org>:
> [ http://issues.apache.org/jira/browse/MYFACES-1284?page=comments#action_12456745 ]
>
> Zdenek Sochor commented on MYFACES-1284:
> ----------------------------------------
>
> If interested i can provide patch to re-enabling code generation for Tomahawk components (at least for components marked with XML file).
>
> I altered generator patch to be able to process more conditions (like supressing generation of setter for property).
>
> I have refactored all components using generation to be consistent with SVN repository (altered files in generation part of files) - i used version of files as of 6/12/2006, but i will update changes in files to current versions prior to making patch.
>
> If used, i will expand auto-generation to allow generating of tags and tld.
> Also i can refactor all remaining components, which currently don't use auto-generation XML file.
>
> In patch i also added support for using selection mode of user roles (TOMAHAWK-489).
>
> Zdenek Sochor
>
> > Generating component source code
> > --------------------------------
> >
> > Key: MYFACES-1284
> > URL: http://issues.apache.org/jira/browse/MYFACES-1284
> > Project: MyFaces Core
> > Issue Type: Improvement
> > Components: build process
> > Reporter: Gert Vanthienen
> > Assigned To: Matthias Weßendorf
> > Priority: Minor
> > Attachments: build-tools-generator.patch, core-generator.patch, tomahawk-generator.patch
> >
> >
> > The component code generator has been re-added to the Myfaces build process by Manfred Geiler, but there is still some work to be done. For a description, see also http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] Commented: (MYFACES-1284) Generating component source code
Posted by "Gert Vanthienen (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1284?page=comments#action_12374492 ]
Gert Vanthienen commented on MYFACES-1284:
------------------------------------------
Currently, in order to make a Tomahawk component DisplayValueOnlyCapable, you have to make these changes to a component's XML file:
- specify generateDisplayValueOnlyMethods="true" in order to get the isSetDisplayValueOnly()-method generated
- specify a boolean field named displayValueOnly
- specify a String field named displayValueOnlyStyle
- specify a String field named displayValueOnlyStyleClass
Wouldn't it make sense to specify all this in a single attribute (e.g. isDisplayValueOnlyCapable="true") instead of repeating the same definitions over and over again? Not only would this simplify the XML file, it would also make future changes to the DisplayValueOnlyCapable interface easier to implement.
In my opinion, the same goes for a set of other Tomahawk interfaces (e.g. UserRoleAware, EscapeCapable).
> Generating component source code
> --------------------------------
>
> Key: MYFACES-1284
> URL: http://issues.apache.org/jira/browse/MYFACES-1284
> Project: MyFaces Core
> Type: Improvement
> Components: build process
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: build-tools-generator.patch, tomahawk-generator.patch
>
> The component code generator has been re-added to the Myfaces build process by Manfred Geiler, but there is still some work to be done. For a description, see also http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1284) Generating component source code
Posted by "Zdenek Sochor (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1284?page=comments#action_12456745 ]
Zdenek Sochor commented on MYFACES-1284:
----------------------------------------
If interested i can provide patch to re-enabling code generation for Tomahawk components (at least for components marked with XML file).
I altered generator patch to be able to process more conditions (like supressing generation of setter for property).
I have refactored all components using generation to be consistent with SVN repository (altered files in generation part of files) - i used version of files as of 6/12/2006, but i will update changes in files to current versions prior to making patch.
If used, i will expand auto-generation to allow generating of tags and tld.
Also i can refactor all remaining components, which currently don't use auto-generation XML file.
In patch i also added support for using selection mode of user roles (TOMAHAWK-489).
Zdenek Sochor
> Generating component source code
> --------------------------------
>
> Key: MYFACES-1284
> URL: http://issues.apache.org/jira/browse/MYFACES-1284
> Project: MyFaces Core
> Issue Type: Improvement
> Components: build process
> Reporter: Gert Vanthienen
> Assigned To: Matthias Weßendorf
> Priority: Minor
> Attachments: build-tools-generator.patch, core-generator.patch, tomahawk-generator.patch
>
>
> The component code generator has been re-added to the Myfaces build process by Manfred Geiler, but there is still some work to be done. For a description, see also http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (MYFACES-1284) Generating component source code
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-1284.
-------------------------------------
Resolution: Fixed
Assignee: Leonardo Uribe (was: Matthias Weßendorf)
this was fixed with the introduction of myfaces-builder-plugin, so this issue could be considered as fixed
> Generating component source code
> --------------------------------
>
> Key: MYFACES-1284
> URL: https://issues.apache.org/jira/browse/MYFACES-1284
> Project: MyFaces Core
> Issue Type: Improvement
> Components: build process
> Reporter: Gert Vanthienen
> Assignee: Leonardo Uribe
> Priority: Minor
> Attachments: build-tools-generator.patch, core-generator.patch, tomahawk-generator.patch
>
>
> The component code generator has been re-added to the Myfaces build process by Manfred Geiler, but there is still some work to be done. For a description, see also http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1284) Generating component source code
Posted by "Gert Vanthienen (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1284?page=comments#action_12374489 ]
Gert Vanthienen commented on MYFACES-1284:
------------------------------------------
With these first two patch files, Tomahawk component code can now also be generated by the Maven build process (using the '-P regenerate-component-code' switch).
However, the resulting code will not compile due to:
1) duplicate field/method names (same field/method generated code and the code that was manually added)
2) missing or incorrect definitions in some of the XML files that define the code generation process
As soon as these initial patches are applied, we can continue to work on the second item (fixing the XML files) for now, as these changes should not interfere with the upcoming 1.1.2 release (as long as you do not enable Maven's code generation switch, that is).
> Generating component source code
> --------------------------------
>
> Key: MYFACES-1284
> URL: http://issues.apache.org/jira/browse/MYFACES-1284
> Project: MyFaces Core
> Type: Improvement
> Components: build process
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: build-tools-generator.patch, tomahawk-generator.patch
>
> The component code generator has been re-added to the Myfaces build process by Manfred Geiler, but there is still some work to be done. For a description, see also http://mail-archives.apache.org/mod_mbox/myfaces-dev/200604.mbox/%3c564d4f680604130149m100b83cfibf4816ea9ccfbe87@mail.gmail.com%3e
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira