You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/04 16:21:52 UTC

[GitHub] [incubator-tvm] wpan11nv commented on a change in pull request #5727: ROCm warp shuffles and reductions

wpan11nv commented on a change in pull request #5727:
URL: https://github.com/apache/incubator-tvm/pull/5727#discussion_r435386022



##########
File path: src/target/llvm/intrin_rule_rocm.cc
##########
@@ -40,8 +41,59 @@ inline void DispatchExternOCML(const TVMArgs& args, TVMRetValue* rv) {
   *rv = CallNode::make(call->dtype, intrinsic_name.str(), call->args, CallNode::PureExtern);
 }
 
+inline void DispatchShuffle(const TVMArgs& targs, TVMRetValue* rv) {
+  PrimExpr e = targs[0];

Review comment:
       Let's use more descriptive names for all arguments. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org