You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by GitBox <gi...@apache.org> on 2022/11/14 14:26:21 UTC
[GitHub] [johnzon] rmannibucau commented on a diff in pull request #96: update maven plugins
rmannibucau commented on code in PR #96:
URL: https://github.com/apache/johnzon/pull/96#discussion_r1021602898
##########
.github/workflows/maven.yml:
##########
@@ -22,10 +22,7 @@ jobs:
distribution: ${{ matrix.dist }}
cache: 'maven'
- - name: Maven Package
+ - name: Maven Verify
env:
MAVEN_OPTS: -Dmaven.artifact.threads=64
- run: mvn -V package --no-transfer-progress
-
- #- name: Maven javadoc
- # run: mvn javadoc:javadoc -Ddoclint=all --no-transfer-progress
+ run: mvn -V verify --no-transfer-progress
Review Comment:
we don't need verify AFAIK so let's not misguide users/us with an irrelevant command in the project
##########
pom.xml:
##########
@@ -397,7 +442,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <version>3.0.0-M3</version>
+ <!-- Version defined in Apache parent pom -->
Review Comment:
same but can be upgraded ;)
##########
pom.xml:
##########
@@ -239,7 +286,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.5.1</version>
Review Comment:
same
##########
pom.xml:
##########
@@ -375,7 +421,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>3.2.0</version>
+ <!-- Version defined in Apache parent pom -->
Review Comment:
same
##########
pom.xml:
##########
@@ -517,12 +523,11 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
- <version>3.5.1</version>
+ <!-- Version defined in Apache parent pom -->
Review Comment:
same
##########
pom.xml:
##########
@@ -103,7 +116,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.3</version>
+ <!-- Version defined in Apache parent pom -->
Review Comment:
let's keep it there to not be unstable due to "external" parent pom
##########
pom.xml:
##########
@@ -470,25 +494,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
- <version>3.0.0-M2</version>
- <executions>
- <execution>
- <id>enforce-versions</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <configuration>
- <rules>
- <requireMavenVersion>
- <version>[3.3,)</version>
- </requireMavenVersion>
- <requireJavaVersion>
- <version>[${java-compile.version},)</version>
- </requireJavaVersion>
- </rules>
- </configuration>
- </execution>
- </executions>
+ <!-- Version (and configuration) defined in Apache parent pom -->
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org