You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/07/09 22:09:56 UTC
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10896
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Define TestKuduMetastorePlugin test data directory at runtime
This is preliminary work needed to run the java tests
on dist-test.
Currently the TestKuduMetastorePlugin test data directory
is defined at build time and passed via a system variable
to the hive-site.xml. This change instead defines the data
directory at test runtime. It also changes the @BeforeClass tag
to a @Before tag to ensure tests are isolated.
Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
---
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
D java/kudu-hive/src/test/resources/hive-site.xml
4 files changed, 41 insertions(+), 75 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10896/1
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@50
PS1, Line 50: private static final Logger LOG = LoggerFactory.getLogger(TestKuduMetastorePlugin.class);
> I noticed in your other patch that we sometimes prefer using "TestKuduMetas
Which other patch? Not sure I understand.
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@79
PS1, Line 79: hiveTestDir.toFile().deleteOnExit(); // Ensure we cleanup state.
> To make sure I understand, this doesn't happen at `tearDown()`, but when th
When the JVM is exited.
http://gerrit.cloudera.org:8080/#/c/10896/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@100
PS2, Line 100: clientConf = new HiveConf();
> No longer used.
My bad. I meant to put the usage back.
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 17:46:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@89
PS1, Line 89: // Set where derby logs.
sentence fragment
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 09 Jul 2018 22:17:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10896/3/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/3/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@103
PS3, Line 103: metastoreConf
> should this be clientConf?
yeah...
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 18:36:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10896
to look at the new patch set (#4).
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Define TestKuduMetastorePlugin test data directory at runtime
This is preliminary work needed to run the java tests
on dist-test.
Currently the TestKuduMetastorePlugin test data directory
is defined at build time and passed via a system variable
to the hive-site.xml. This change instead defines the data
directory at test runtime. It also changes the @BeforeClass tag
to a @Before tag to ensure tests are isolated.
Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
---
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
D java/kudu-hive/src/test/resources/hive-site.xml
4 files changed, 45 insertions(+), 75 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10896/4
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10896/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@100
PS2, Line 100: clientConf = new HiveConf();
No longer used.
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 17:45:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10896
to look at the new patch set (#3).
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Define TestKuduMetastorePlugin test data directory at runtime
This is preliminary work needed to run the java tests
on dist-test.
Currently the TestKuduMetastorePlugin test data directory
is defined at build time and passed via a system variable
to the hive-site.xml. This change instead defines the data
directory at test runtime. It also changes the @BeforeClass tag
to a @Before tag to ensure tests are isolated.
Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
---
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
D java/kudu-hive/src/test/resources/hive-site.xml
4 files changed, 46 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10896/3
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10896/3/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/3/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@103
PS3, Line 103: metastoreConf
should this be clientConf?
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 18:36:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10896
to look at the new patch set (#2).
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Define TestKuduMetastorePlugin test data directory at runtime
This is preliminary work needed to run the java tests
on dist-test.
Currently the TestKuduMetastorePlugin test data directory
is defined at build time and passed via a system variable
to the hive-site.xml. This change instead defines the data
directory at test runtime. It also changes the @BeforeClass tag
to a @Before tag to ensure tests are isolated.
Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
---
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
D java/kudu-hive/src/test/resources/hive-site.xml
4 files changed, 47 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/10896/2
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 19:13:16 +0000
Gerrit-HasComments: No
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@50
PS1, Line 50: private static final Logger LOG = LoggerFactory.getLogger(TestKuduMetastorePlugin.class);
> Which other patch? Not sure I understand.
Ah, nevermind. I was conflating Logger setup with table name setup. E.g.
https://gerrit.cloudera.org/c/10838/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java#35
and
https://gerrit.cloudera.org/c/10838/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java#47
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 18:26:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Define TestKuduMetastorePlugin test data directory at runtime
This is preliminary work needed to run the java tests
on dist-test.
Currently the TestKuduMetastorePlugin test data directory
is defined at build time and passed via a system variable
to the hive-site.xml. This change instead defines the data
directory at test runtime. It also changes the @BeforeClass tag
to a @Before tag to ensure tests are isolated.
Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Reviewed-on: http://gerrit.cloudera.org:8080/10896
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
D java/kudu-hive/src/test/resources/hive-site.xml
4 files changed, 45 insertions(+), 75 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Define TestKuduMetastorePlugin test data directory at runtime
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10896 )
Change subject: Define TestKuduMetastorePlugin test data directory at runtime
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java:
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@50
PS1, Line 50: private static final Logger LOG = LoggerFactory.getLogger(TestKuduMetastorePlugin.class);
I noticed in your other patch that we sometimes prefer using "TestKuduMetastorePlugin", why the *.class here?
http://gerrit.cloudera.org:8080/#/c/10896/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@79
PS1, Line 79: hiveTestDir.toFile().deleteOnExit(); // Ensure we cleanup state.
To make sure I understand, this doesn't happen at `tearDown()`, but when the test environment gets torn down, right?
--
To view, visit http://gerrit.cloudera.org:8080/10896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39a81b891b2dd2a7e9d3248facfad4265ec61deb
Gerrit-Change-Number: 10896
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 09 Jul 2018 22:37:54 +0000
Gerrit-HasComments: Yes