You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2011/06/09 23:57:59 UTC
[jira] [Created] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
hadoop-config.sh shouldn't add tools.jar to the classpath
---------------------------------------------------------
Key: HADOOP-7374
URL: https://issues.apache.org/jira/browse/HADOOP-7374
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Reporter: Eli Collins
Assignee: Eli Collins
bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7374:
--------------------------------
Attachment: hadoop-7374-1.patch
Patch attached. Ran the hdfs and mr daemons and looked at the web UIs for sanity.
> hadoop-config.sh shouldn't add tools.jar to the classpath
> ---------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7374:
--------------------------------
Status: Patch Available (was: Open)
> hadoop-config.sh shouldn't add tools.jar to the classpath
> ---------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047009#comment-13047009 ]
Hadoop QA commented on HADOOP-7374:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481985/hadoop-7374-1.patch
against trunk revision 1133125.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/605//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/605//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/605//console
This message is automatically generated.
> hadoop-config.sh shouldn't add tools.jar to the classpath
> ---------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046863#comment-13046863 ]
Owen O'Malley commented on HADOOP-7374:
---------------------------------------
The thing to test is that the tools still run: distcp, har, etc.
> hadoop-config.sh shouldn't add tools.jar to the classpath
> ---------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) Don't add tools.jar to the
classpath when running Hadoop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048298#comment-13048298 ]
Hudson commented on HADOOP-7374:
--------------------------------
Integrated in Hadoop-Common-trunk #717 (See [https://builds.apache.org/job/Hadoop-Common-trunk/717/])
HADOOP-7374. Don't add tools.jar to the classpath when running Hadoop. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134861
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/bin/hadoop-config.sh
* /hadoop/common/trunk/bin/rcc
> Don't add tools.jar to the classpath when running Hadoop
> --------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046999#comment-13046999 ]
Eli Collins commented on HADOOP-7374:
-------------------------------------
Thanks Owen. I tested distcp and har. I also grepped the sources for the package names in tools.jar and that didn't turn up anything so I think the code is clear. The only dependency looks like Jasper to compile the jsps, but that's a build-time dependency.
Attached (trivial) patch look good?
> hadoop-config.sh shouldn't add tools.jar to the classpath
> ---------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7374) Don't add tools.jar to the classpath
when running Hadoop
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7374:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Don't add tools.jar to the classpath when running Hadoop
> --------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) Don't add tools.jar to the
classpath when running Hadoop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048229#comment-13048229 ]
Hudson commented on HADOOP-7374:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #649 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/649/])
HADOOP-7374. Don't add tools.jar to the classpath when running Hadoop. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134861
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/bin/hadoop-config.sh
* /hadoop/common/trunk/bin/rcc
> Don't add tools.jar to the classpath when running Hadoop
> --------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) Don't add tools.jar to the
classpath when running Hadoop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048275#comment-13048275 ]
Hudson commented on HADOOP-7374:
--------------------------------
Integrated in Hadoop-Common-trunk-maven #13 (See [https://builds.apache.org/job/Hadoop-Common-trunk-maven/13/])
HADOOP-7374. Don't add tools.jar to the classpath when running Hadoop. Contributed by Eli Collins
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134861
Files :
* /hadoop/common/trunk/CHANGES.txt
* /hadoop/common/trunk/bin/hadoop-config.sh
* /hadoop/common/trunk/bin/rcc
> Don't add tools.jar to the classpath when running Hadoop
> --------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7374) hadoop-config.sh shouldn't add
tools.jar to the classpath
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048218#comment-13048218 ]
Todd Lipcon commented on HADOOP-7374:
-------------------------------------
+1
> hadoop-config.sh shouldn't add tools.jar to the classpath
> ---------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7374) Don't add tools.jar to the classpath
when running Hadoop
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7374:
--------------------------------
Fix Version/s: 0.23.0
Release Note: The scripts that run Hadoop no longer automatically add tools.jar from the JDK to the classpath (if it is present). If your job depends on tools.jar in the JDK you will need to add this dependency in your job.
Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change])
Summary: Don't add tools.jar to the classpath when running Hadoop (was: hadoop-config.sh shouldn't add tools.jar to the classpath)
Thanks Todd! I've committed this.
> Don't add tools.jar to the classpath when running Hadoop
> --------------------------------------------------------
>
> Key: HADOOP-7374
> URL: https://issues.apache.org/jira/browse/HADOOP-7374
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.23.0
>
> Attachments: hadoop-7374-1.patch
>
>
> bin/hadoop-config.sh (and bin/rcc) add lib/tools.jar from JAVA_HOME to the classpath. This has been there since the initial commit of bin/hadoop, but I don't think it's needed. *Executing* Hadoop does not depend on tools.jar (or other libraries only available in the JDK, not the JRE) so let's not automatically add it. Marking this as an incompatible change since a job could potentially have relied on Hadoop adding tools.jar to the CLASSPATH automatically (though such a job would not have run on a system that did not have JAVA_HOME point to a jdk). The build of course still requires a JDK.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira