You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ke...@apache.org on 2025/05/22 22:29:04 UTC
(iceberg-rust) branch main updated: Run dependency license check in release script (#1367)
This is an automated email from the ASF dual-hosted git repository.
kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git
The following commit(s) were added to refs/heads/main by this push:
new 2f313c9a Run dependency license check in release script (#1367)
2f313c9a is described below
commit 2f313c9a22e49cfa6148dc9ff5658e9d2a18e152
Author: Kevin Liu <ke...@users.noreply.github.com>
AuthorDate: Thu May 22 18:28:58 2025 -0400
Run dependency license check in release script (#1367)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
Adds `python3 ./scripts/dependencies.py check` to the release script.
This will check dependencies' licenses. Helps prevent issue like #1345
where the `DEPENDENCIES.rust.tsv` files were accidentally removed
Also moved apache license check to the beginning of the release script
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes, verified by running
```
ICEBERG_VERSION=0.5.0 ICEBERG_VERSION_RC=2 ./scripts/release.sh
```
---
scripts/release.sh | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/scripts/release.sh b/scripts/release.sh
index 884ed8a0..1f66b359 100755
--- a/scripts/release.sh
+++ b/scripts/release.sh
@@ -38,10 +38,19 @@ mkdir -p dist/
echo "> Checkout version branch"
git checkout -B "${git_branch}"
+# Run a few checks
+echo "> Check license"
+docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
+
+echo "> Run dependency license check using cargo-deny"
+python3 ./scripts/dependencies.py check
+
+# Generate and verify artifacts
echo "> Start package"
git archive --format=tar.gz --output="dist/apache-iceberg-rust-$release_version-src.tar.gz" --prefix="apache-iceberg-rust-$release_version-src/" --add-file=Cargo.toml "$git_branch"
cd dist
+
echo "> Generate signature"
for i in *.tar.gz; do
echo "$i"
@@ -62,7 +71,3 @@ for i in *.tar.gz; do
echo "$i"
sha512sum --check "$i.sha512"
done
-
-cd ..
-echo "> Check license"
-docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check