You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2007/10/07 11:22:12 UTC
[PATCH] Fix Neon-0.27-related warning and fix bug introduced in r26820
r26820 introduced a bug which causes that SVN_NEON_0_26 is never defined.
Autoconf expands
if test -n "`echo \"$NEON_VERSION\" | grep '^0\.2[6-7]\.'`" ; then
to
if echo "$NEON_VERSION" | grep -q '^0\.26-7\.' ; then
Additional [ and ] should be placed somewhere outside.
I'm attaching a patch which also fixes Neon-0.27-related warning.
[[[
Fix Neon-0.27-related warning and fix bug introduced in r26820.
* build/ac-macros/neon.m4
Introduce SVN_NEON_0_27 and fix quoting.
* subversion/libsvn_ra_neon/session.c
(ra_neon_neonprogress): Use SVN_NEON_0_27.
Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
]]]
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Fix Neon-0.27-related warning and fix bug introduced in r26820
Posted by Erik Huelsmann <eh...@gmail.com>.
On 10/8/07, Daniel L. Rall <dl...@collab.net> wrote:
> On Sun, 07 Oct 2007, Arfrever Frehtes Taifersar Arahesis wrote:
>
> > r26820 introduced a bug which causes that SVN_NEON_0_26 is never defined.
> >
> > Autoconf expands
> > if test -n "`echo \"$NEON_VERSION\" | grep '^0\.2[6-7]\.'`" ; then
> > to
> > if echo "$NEON_VERSION" | grep -q '^0\.26-7\.' ; then
> >
> > Additional [ and ] should be placed somewhere outside.
> >
> > I'm attaching a patch which also fixes Neon-0.27-related warning.
>
> Thanks Arfrever, committed to trunk in r27007.
Aren't square brackets bashisms?
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix Neon-0.27-related warning and fix bug introduced in r26820
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Mon, 08 Oct 2007, Arfrever Frehtes Taifersar Arahesis wrote:
> 2007-10-08 04:24 Daniel L. Rall <dl...@collab.net> napisał(a):
> > Thanks Arfrever, committed to trunk in r27007.
>
> Thanks. You can again fix svn:log :) :
>
> - Fix bug where SVN_NEON_0_27 isn't defined when it should be (injected
> + Fix bug where SVN_NEON_0_26 isn't defined when it should be (injected
Thanks, done with continued mention of SVN_NEON_0_27.
--
Daniel Rall
Re: [PATCH] Fix Neon-0.27-related warning and fix bug introduced in r26820
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2007-10-08 04:24 Daniel L. Rall <dl...@collab.net> napisał(a):
> Thanks Arfrever, committed to trunk in r27007.
Thanks. You can again fix svn:log :) :
- Fix bug where SVN_NEON_0_27 isn't defined when it should be (injected
+ Fix bug where SVN_NEON_0_26 isn't defined when it should be (injected
2007-10-08 10:38 Erik Huelsmann <eh...@gmail.com> napisał(a):
> Aren't square brackets bashisms?
In this case external brackets are already handled by autoconf while
internal brackets (around 6-7) belong to an regular expression handled
by grep.
([[ <tested_expression> ]] is bashism. [ <tested_expression> ] is not.)
Re: [PATCH] Fix Neon-0.27-related warning and fix bug introduced in r26820
Posted by "Daniel L. Rall" <dl...@collab.net>.
On Sun, 07 Oct 2007, Arfrever Frehtes Taifersar Arahesis wrote:
> r26820 introduced a bug which causes that SVN_NEON_0_26 is never defined.
>
> Autoconf expands
> if test -n "`echo \"$NEON_VERSION\" | grep '^0\.2[6-7]\.'`" ; then
> to
> if echo "$NEON_VERSION" | grep -q '^0\.26-7\.' ; then
>
> Additional [ and ] should be placed somewhere outside.
>
> I'm attaching a patch which also fixes Neon-0.27-related warning.
Thanks Arfrever, committed to trunk in r27007.
--
Daniel Rall