You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krishna <n_...@yahoo.com> on 2011/06/10 14:00:27 UTC

Review Request: Patch for Hive-2209, extending ObjectInspectorUtils.compare with some map comparison implementations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/879/
-----------------------------------------------------------

Review request for hive and Yongqiang He.


Summary
-------

Patch for HIVE-2209


Diffs
-----

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/CrossMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 2b77072 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SimpleMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestCrossMapEqualcomparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSimpleMapEqualcomparer.java PRE-CREATION 

Diff: https://reviews.apache.org/r/879/diff


Testing
-------

Tests added


Thanks,

Krishna


Re: Review Request: Patch for Hive-2209, extending ObjectInspectorUtils.compare with some map comparison implementations

Posted by Krishna <n_...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/879/
-----------------------------------------------------------

(Updated 2011-07-20 02:25:36.169590)


Review request for hive and Yongqiang He.


Summary
-------

Patch for HIVE-2209


This addresses bug HIVE-2209.
    https://issues.apache.org/jira/browse/HIVE-2209


Diffs
-----

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/CrossMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/FullMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 2b77072 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SimpleMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestCrossMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestFullMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSimpleMapEqualComparer.java PRE-CREATION 

Diff: https://reviews.apache.org/r/879/diff


Testing
-------

Tests added


Thanks,

Krishna


Re: Review Request: Patch for Hive-2209, extending ObjectInspectorUtils.compare with some map comparison implementations

Posted by Krishna <n_...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/879/
-----------------------------------------------------------

(Updated 2011-06-20 12:54:09.245202)


Review request for hive and Yongqiang He.


Changes
-------

Fixed a lowercase/uppercase typo in the test classes 


Summary
-------

Patch for HIVE-2209


Diffs (updated)
-----

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/CrossMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/FullMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 2b77072 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SimpleMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestCrossMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestFullMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSimpleMapEqualComparer.java PRE-CREATION 

Diff: https://reviews.apache.org/r/879/diff


Testing
-------

Tests added


Thanks,

Krishna


Re: Review Request: Patch for Hive-2209, extending ObjectInspectorUtils.compare with some map comparison implementations

Posted by Krishna <n_...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/879/
-----------------------------------------------------------

(Updated 2011-06-17 07:52:38.058921)


Review request for hive and Yongqiang He.


Changes
-------

Added a complete compare implementation too, with sorting of the keys 


Summary
-------

Patch for HIVE-2209


Diffs (updated)
-----

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/CrossMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/FullMapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MapEqualComparer.java PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 2b77072 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SimpleMapEqualComparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestCrossMapEqualcomparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestFullMapEqualcomparer.java PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSimpleMapEqualcomparer.java PRE-CREATION 

Diff: https://reviews.apache.org/r/879/diff


Testing
-------

Tests added


Thanks,

Krishna