You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by WeichenXu123 <gi...@git.apache.org> on 2016/08/01 15:49:04 UTC
[GitHub] spark pull request #14440: [SPARK-16835][ML] add training data unpersist han...
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/14440
[SPARK-16835][ML] add training data unpersist handling when throw exception
[SPARK-16835][ML] add training data `unpersist` handling when throw exception
## What changes were proposed in this pull request?
to `LinearRegression`, `LogisticRegression`, `AFTSuvivalRegression`
modify the `unpersist` call to input training `Dataset` to make sure that
even when exception throws, the `unpersist` will be called.
## How was this patch tested?
Existing test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WeichenXu123/spark glm_traindata_unpersist_on_exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14440
----
commit 1a366e6d382ea1e5156ae5d75c6600a2d414295e
Author: WeichenXu <we...@outlook.com>
Date: 2016-07-26T07:25:01Z
glm_traindata_unpersist_on_exception
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14440: [SPARK-16835][ML] add training data unpersist handling w...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14440
My only problem with this change is that, really, by the same argument just about every use of persisted RDDs needs something like this. It's actually manual memory management all over again.
I think we generally don't handle trying to unpersist in case of exceptions because they get unpersisted anyway soon enough, and exceptions are rare. We'd do this if somehow they wouldn't get unpersisted, or the exception path is common.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14440: [SPARK-16835][ML] add training data unpersist han...
Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/14440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14440: [SPARK-16835][ML] add training data unpersist handling w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14440
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14440: [SPARK-16835][ML] add training data unpersist handling w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14440
**[Test build #63084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63084/consoleFull)** for PR 14440 at commit [`1a366e6`](https://github.com/apache/spark/commit/1a366e6d382ea1e5156ae5d75c6600a2d414295e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14440: [SPARK-16835][ML] add training data unpersist handling w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14440
**[Test build #63084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63084/consoleFull)** for PR 14440 at commit [`1a366e6`](https://github.com/apache/spark/commit/1a366e6d382ea1e5156ae5d75c6600a2d414295e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14440: [SPARK-16835][ML] add training data unpersist handling w...
Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/14440
sounds reasonable...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14440: [SPARK-16835][ML] add training data unpersist handling w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63084/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org