You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zhouyifan279 (via GitHub)" <gi...@apache.org> on 2023/10/19 09:43:41 UTC
[PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
zhouyifan279 opened a new pull request, #5480:
URL: https://github.com/apache/kyuubi/pull/5480
### _Why are the changes needed?_
When using Kyuubi Hive JDBC to Hive Server2, TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10 is used and can not be changed.
When we connected to Hive Server2 with version lower than 2.2.0, we got the following error:
```
org.apache.kyuubi.shade.org.apache.thrift.TApplicationException:
Required field 'client_protocol' is unset!
Struct:TOpenSessionReq(client_protocol:null, configuration:{kyuubi.client.version=1.7.3, set:hiveconf:hive.server2.thrift.resultset.default.fetch.size=1000, kyuubi.client.ipAddress=172.16.19.113, use:database=default})
```
In this PR, we introduced a session conf `clientProtocolVersion`.
By adding `clientProtocolVersion=8` to jdbc url, the error got fixed.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Manual tests against Hive Server2 version 2.1.1-cdh6.3.0
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#issuecomment-1770922393
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5480?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5480](https://app.codecov.io/gh/apache/kyuubi/pull/5480?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c99fc48) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/48bdc7d4cb9023a5de6bef2a10f3ea7512f1940d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (48bdc7d) will **not change** coverage.
> Report is 1 commits behind head on master.
> The diff coverage is `0.00%`.
> :exclamation: Current head c99fc48 differs from pull request most recent head dc16a05. Consider uploading reports for the commit dc16a05 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5480 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33466 33479 +13
Branches 4401 4404 +3
======================================
- Misses 33466 33479 +13
```
| [Files](https://app.codecov.io/gh/apache/kyuubi/pull/5480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../apache/kyuubi/jdbc/hive/JdbcConnectionParams.java](https://app.codecov.io/gh/apache/kyuubi/pull/5480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9KZGJjQ29ubmVjdGlvblBhcmFtcy5qYXZh) | `0.00% <ø> (ø)` | |
| [...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java](https://app.codecov.io/gh/apache/kyuubi/pull/5480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9VdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java](https://app.codecov.io/gh/apache/kyuubi/pull/5480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlDb25uZWN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1376067079
##########
docs/client/jdbc/kyuubi_jdbc.rst:
##########
@@ -147,6 +147,28 @@ Connection URL over Service Discovery
- zookeeper quorum is the corresponding zookeeper cluster configured by `kyuubi.ha.addresses` at the server side.
- zooKeeperNamespace is the corresponding namespace configured by `kyuubi.ha.namespace` at the server side.
+HiveServer2 Compatibility
+*************************
+
+.. versionadded:: 1.8.0
Review Comment:
rc1 is coming ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#issuecomment-1770865063
Docs updated
![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#issuecomment-1784399510
> Restore client protocol version backup V10 so the default behavior won't change
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1365466952
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >= HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
also cc Hive experts @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1375619263
##########
docs/client/jdbc/kyuubi_jdbc.rst:
##########
@@ -147,6 +147,28 @@ Connection URL over Service Discovery
- zookeeper quorum is the corresponding zookeeper cluster configured by `kyuubi.ha.addresses` at the server side.
- zooKeeperNamespace is the corresponding namespace configured by `kyuubi.ha.namespace` at the server side.
+HiveServer2 Compatibility
+*************************
+
+.. versionadded:: 1.8.0
+
+JDBC Drivers need to negotiate a protocol version with Kyuubi Server/HiveServer2 when connecting.
+
+In order to support most HiveServer2 versions (since Hive 0.13.0),
+Kyuubi Hive JDBC Driver offers protocol version v6 (`clientProtocolVersion=5`) to server by default.
Review Comment:
outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1366562892
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >= HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
Kyuubi JDBC uses `HIVE_CLI_SERVICE_PROTOCOL_V10`,
`TOpenSessionReq.TOpenSessionReqStandardScheme#read` returns null because there is no corresponding protocol version.
So there is `Required field 'client_protocol' is unset! ` in the PR description.
https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java#L580
If Kyuubi JDBC uses a lower version, HS2 will compare the currently known version, find the minimum version number, and return it to the Client.
https://github.com/apache/hive/blob/b02cef4fe943b9aba597dcdfd3b8f3d3a5efca3e/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java#L556-L557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1368103365
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >= HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
Kyuubi currently determines whether to return TIMEDOUT_STATE based on the client's protocol version.
https://github.com/apache/kyuubi/issues/2112
v7
0.13.0
[HIVE-6647](https://issues.apache.org/jira/browse/HIVE-6647) : Bump the thrift api version to V7 for HiveServer2
v8
1.2.0
[HIVE-10037](https://issues.apache.org/jira/browse/HIVE-10037): JDBC support for interval expressions
v9
2.2.0
[HIVE-12427](https://issues.apache.org/jira/browse/HIVE-12427): ResultSet performance
[HIVE-14191](https://issues.apache.org/jira/browse/HIVE-14191): bump a new api version for ThriftJDBCBinarySerde changes
org.apache.hive.service.cli.session.HiveSessionImpl#updateIsUsingThriftJDBCBinarySerDe
```java
private boolean updateIsUsingThriftJDBCBinarySerDe() {
return 8 <= getProtocolVersion().getValue() &&
sessionConf.getBoolVar(ConfVars.HIVE_SERVER2_THRIFT_RESULTSET_SERIALIZE_IN_TASKS);
}
```
v10
2.2.0
[HIVE-15473](https://issues.apache.org/jira/browse/HIVE-15473): Progress Bar on Beeline client
[HIVE-15906](https://issues.apache.org/jira/browse/HIVE-15906) : thrift code regeneration to include new protocol version
v11
3.0.0
[HIVE-14412](https://issues.apache.org/jira/browse/HIVE-14412): Add timestamp with time zone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#issuecomment-1770618449
Please update the docs as well, also, I suppose we can set the default protocol to 6 to make the Kyuubi JDBC driver compatible with more versions of HiveServer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1375619263
##########
docs/client/jdbc/kyuubi_jdbc.rst:
##########
@@ -147,6 +147,28 @@ Connection URL over Service Discovery
- zookeeper quorum is the corresponding zookeeper cluster configured by `kyuubi.ha.addresses` at the server side.
- zooKeeperNamespace is the corresponding namespace configured by `kyuubi.ha.namespace` at the server side.
+HiveServer2 Compatibility
+*************************
+
+.. versionadded:: 1.8.0
+
+JDBC Drivers need to negotiate a protocol version with Kyuubi Server/HiveServer2 when connecting.
+
+In order to support most HiveServer2 versions (since Hive 0.13.0),
+Kyuubi Hive JDBC Driver offers protocol version v6 (`clientProtocolVersion=5`) to server by default.
Review Comment:
outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1365465526
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >= HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
is this assumption true? cc @cxzl25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1369681690
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >= HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
I suppose such change is only affected by HIVE-14191?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1375884756
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -733,6 +733,16 @@ private void openSession() throws SQLException {
if (sessVars.containsKey(HS2_PROXY_USER)) {
openConf.put(HS2_PROXY_USER, sessVars.get(HS2_PROXY_USER));
}
+ String clientProtocolStr =
+ sessVars.getOrDefault(
+ CLIENT_PROTOCOL_VERSION, openReq.getClient_protocol().getValue() + "");
+ TProtocolVersion clientProtocol =
+ TProtocolVersion.findByValue(Integer.parseInt(clientProtocolStr));
+ if (clientProtocol == null) {
+ throw new IllegalArgumentException(
Review Comment:
throw exception with `clientProtocolStr` value
##########
docs/client/jdbc/kyuubi_jdbc.rst:
##########
@@ -147,6 +147,28 @@ Connection URL over Service Discovery
- zookeeper quorum is the corresponding zookeeper cluster configured by `kyuubi.ha.addresses` at the server side.
- zooKeeperNamespace is the corresponding namespace configured by `kyuubi.ha.namespace` at the server side.
+HiveServer2 Compatibility
+*************************
+
+.. versionadded:: 1.8.0
Review Comment:
1.8.0 rc0 is already in voting and will be released soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1369473104
##########
docs/deployment/migration-guide.md:
##########
@@ -27,6 +27,10 @@
* Since Kyuubi 1.8, PROMETHEUS is changed as the default metrics reporter. To restore previous behavior,
set `kyuubi.metrics.reporters=JSON`.
+* Since Kyuubi 1.8, Kyuubi Hive JDBC Driver offers protocol version v6 to server by default.
+ To restore previous behavior, add `clientProtocolVersion=9;` to JDBC URL client properties section:
+ `jdbc:subprotocol://host:port[/catalog]/[schema];clientProtocolVersion=9;`
Review Comment:
```suggestion
`jdbc:kyuubi://<host>:<port>[/catalog]/[schema];clientProtocolVersion=9;`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on code in PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#discussion_r1366891285
##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java:
##########
@@ -700,7 +700,9 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory() throws SQLException {
}
private void openSession() throws SQLException {
- TOpenSessionReq openReq = new TOpenSessionReq();
+ // Server responses are the same if TProtocolVersion >= HIVE_CLI_SERVICE_PROTOCOL_V6
Review Comment:
@cxzl25 Except `TOpenSessionReq`, is there any difference in responses of other requests between different protocol versions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5480: Support setting kyuubi hive jdbc client protocol version
URL: https://github.com/apache/kyuubi/pull/5480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] Support setting kyuubi hive jdbc client protocol version [kyuubi]
Posted by "zhouyifan279 (via GitHub)" <gi...@apache.org>.
zhouyifan279 commented on PR #5480:
URL: https://github.com/apache/kyuubi/pull/5480#issuecomment-1784397014
@pan3793 @cxzl25 Restore client protocol version backup V10 so the default behavior won't change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org