You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by drg-bot <no...@github.com> on 2014/04/08 22:01:41 UTC
[jclouds-site] Codify the mvn command (#73)
You can merge this Pull Request by running:
git pull https://github.com/drg-bot/jclouds-site patch-2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/73
-- Commit Summary --
* Codify the mvn command
-- File Changes --
M guides/rackspace.md (2)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/73.patch
https://github.com/jclouds/jclouds-site/pull/73.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73
Re: [jclouds-site] Codify the mvn command (#73)
Posted by Everett Toews <no...@github.com>.
Merged and deployed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73#issuecomment-40415642
Re: [jclouds-site] Codify the mvn command (#73)
Posted by Andrew Phillips <no...@github.com>.
Change renders fine, just one small question...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73#issuecomment-39907833
Re: [jclouds-site] Codify the mvn command (#73)
Posted by jclouds-commentator <no...@github.com>.
Go to http://308e33c49943275b1dfe-d93bdd7dc4d59e01e21f2ae39b6fd510.r16.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73#issuecomment-39895173
Re: [jclouds-site] Codify the mvn command (#73)
Posted by Everett Toews <no...@github.com>.
Closed #73.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73
Re: [jclouds-site] Codify the mvn command (#73)
Posted by Andrew Phillips <no...@github.com>.
> @@ -41,7 +41,7 @@ Likewise you can go to the [Rackspace Cloud (UK)](https://buyonline.rackspace.co
> * `mkdir jclouds`
> * `cd jclouds`
> 1. Make a local copy of this [pom.xml](https://github.com/jclouds/jclouds-examples/blob/master/rackspace/pom.xml) file in the jclouds directory.
> - * mvn dependency:copy-dependencies "-DoutputDirectory=./lib"
> + * `mvn dependency:copy-dependencies "-DoutputDirectory=./lib"`
> In general my experience is that quoting the whole parameter is preferable...
OK, fine to leave as-is, then. +1 - good to go for me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73/files#r11417078
Re: [jclouds-site] Codify the mvn command (#73)
Posted by Andrew Phillips <no...@github.com>.
> @@ -41,7 +41,7 @@ Likewise you can go to the [Rackspace Cloud (UK)](https://buyonline.rackspace.co
> * `mkdir jclouds`
> * `cd jclouds`
> 1. Make a local copy of this [pom.xml](https://github.com/jclouds/jclouds-examples/blob/master/rackspace/pom.xml) file in the jclouds directory.
> - * mvn dependency:copy-dependencies "-DoutputDirectory=./lib"
> + * `mvn dependency:copy-dependencies "-DoutputDirectory=./lib"`
Just out of curiosity, why the quotes around the argument? If it's because of the `.`, how about just `-DoutputDirectory="./lib"`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73/files#r11414270
Re: [jclouds-site] Codify the mvn command (#73)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #236](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/236/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73#issuecomment-39894969
Re: [jclouds-site] Codify the mvn command (#73)
Posted by Zack Shoylev <no...@github.com>.
> @@ -41,7 +41,7 @@ Likewise you can go to the [Rackspace Cloud (UK)](https://buyonline.rackspace.co
> * `mkdir jclouds`
> * `cd jclouds`
> 1. Make a local copy of this [pom.xml](https://github.com/jclouds/jclouds-examples/blob/master/rackspace/pom.xml) file in the jclouds directory.
> - * mvn dependency:copy-dependencies "-DoutputDirectory=./lib"
> + * `mvn dependency:copy-dependencies "-DoutputDirectory=./lib"`
I think windows and also maybe some more complex cases. In general my experience is that quoting the whole parameter is preferable...
I don't have examples or counterexamples right now though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/73/files#r11414461