You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by rob05c <gi...@git.apache.org> on 2017/06/05 16:14:59 UTC

[GitHub] incubator-trafficcontrol pull request #642: Add Traffic Ops username to acce...

GitHub user rob05c opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/642

    Add Traffic Ops username to access log

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rob05c/incubator-trafficcontrol to-logusers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #642
    
----
commit 4c6daac26e5e57352de02334f87545cfffdacbf2
Author: Robert Butts <ro...@gmail.com>
Date:   2017-06-05T16:12:54Z

    Add TO username to access log

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #642: Add Traffic Ops username to access log

Posted by rob05c <gi...@git.apache.org>.

Github user rob05c commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/642
  
    This PR doesn't modify the log format, which was already logging `%u` (which apparently broke sometime in the past), it only makes the logger aware of the username.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #642: Add Traffic Ops username to access log

Posted by mitchell852 <gi...@git.apache.org>.

Github user mitchell852 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/642
  
    this is what the log line looks like now:
    
    127.0.0.1 - - [05/Jun/2017:13:54:34 -0600] "GET /api/1.2/logs/newcount HTTP/1.1" 200 51 25823 "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36"
    
    so, yea, @dew it looks like the %u is there...it's just blank...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #642: Add Traffic Ops username to access log

Posted by mitchell852 <gi...@git.apache.org>.

Github user mitchell852 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/642
  
    Tested locally, here were my results:
    
    127.0.0.1 - localUsername [05/Jun/2017:13:38:48 -0600] "GET /api/1.2/logs/newcount HTTP/1.1" 200 51 7370 "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36"
    
    ^^ local database user
    
    127.0.0.1 - ldapUsername [05/Jun/2017:13:39:07 -0600] "GET /newlogcount HTTP/1.1" 200 38 4830 "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36"
    
    ^^ ldap user (user is not found in the database)
    
    @dewrich or @dangogh  - any concerns?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #642: Add Traffic Ops username to access log

Posted by dewrich <gi...@git.apache.org>.

Github user dewrich commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/642
  
    I think putting the username at the "end" of the line is better in case there are any logs scrapers concerned with that format.  Otherwise I think the localUsername vs. the ldapUsername seems correct to be logged accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #642: Add Traffic Ops username to acce...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafficcontrol/pull/642


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---