[GitHub] [hadoop] steveloughran commented on a diff in pull request #5372: HDFS-16904. Close webhdfs during TestSymlinkHdfs teardown

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #5372:
URL: https://github.com/apache/hadoop/pull/5372#discussion_r1101277484


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfs.java:
##########
@@ -100,7 +100,7 @@ public static void afterClassTeardown() throws Exception {
     if (cluster != null) {
       cluster.shutdown();
     }
-    IOUtils.closeQuietly(webhdfs);
+    IOUtils.closeStream(webhdfs);

Review Comment:
   realy, I always thought closeStream() would pass in the default logger if none set. If that is *not the case* then we should fix it...it gets used in a lot of places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org