You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jlprat (via GitHub)" <gi...@apache.org> on 2024/02/21 09:32:45 UTC
[PR] MINOR: Update dependencies [kafka]
jlprat opened a new pull request, #15404:
URL: https://github.com/apache/kafka/pull/15404
Updates minor versions for our dependencies and build tool
- Jackson from 2.16.0 to 2.16.1
- JUnit from 5.10.0 to 5.10.2 https://junit.org/junit5/docs/5.10.2/release-notes/ and https://junit.org/junit5/docs/5.10.1/release-notes/
- Mockito from 5.8.0 to 5.10.0 (only if JDK 11 or higher) https://github.com/mockito/mockito/releases/tag/v5.10.0 and https://github.com/mockito/mockito/releases/tag/v5.9.0
- Gradle from 8.5 to 8.6 https://docs.gradle.org/8.6/release-notes.html
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956451482
It must have been fixed by https://github.com/apache/kafka/commit/cc49fc76564b15f2111801faf62341aaf01c4d8c
Perhaps a rebase from trunk should help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1958953132
@divijvaidya as you already partially reviewed this, do you mind finishing the review?
Also to which versions did you think this should be backported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956402963
Please update license of jackson here - https://github.com/apache/kafka/blob/cc49fc76564b15f2111801faf62341aaf01c4d8c/LICENSE-binary#L219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1497178970
##########
gradlew:
##########
Review Comment:
Changes in this file are auto-generated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1528029938
##########
gradle/dependencies.gradle:
##########
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8.5",
+ gradle: "8.6",
Review Comment:
https://github.com/apache/kafka/pull/15553 PR reverting to the old version.
@pasharik have you reported the bug (if it is indeed a bug in Gradle) to the upstream project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1526810480
##########
gradle/dependencies.gradle:
##########
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8.5",
+ gradle: "8.6",
Review Comment:
That's a big deal, we should probably revert to the older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1959312473
> Regarding a backport to the 3.6 branch, Gradle version over there is 8.2.1, it's a bit of a jump I believe.
Ok, no worries. Let's keep it limited to 3.7.x. We can always revisit updating dependencies if/when we start a patch fix for 3.6.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956458474
Rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "pasharik (via GitHub)" <gi...@apache.org>.
pasharik commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1530262197
##########
gradle/dependencies.gradle:
##########
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8.5",
+ gradle: "8.6",
Review Comment:
@jlprat my `trunk` branch was almost 2 weeks old, now I've updated it and I can't see any difference between Gradle 8.5 and 8.6. So I think we can leave this PR as it is, sorry for the confusion.
I didn't report issue to the Gradle yet, still trying to figure out exact steps how to reproduce it, and if it's related to Gradle or to my local environment setup.
Not related to this particular PR, but I still can see issues with incremental compilation, only when making changes from IntelliJ Idea. If changes are made from vim or other console text editor, incremental compilation works as expected.
Steps to reproduce:
* Open `kafka.admin.AclCommandTest` in IntelliJ Idea. I'm using `2023.3.5 Ultimate`
* Add `println("a")` at the beginning of `testAclCliWithAuthorizer` method
* Run in terminal: `./gradlew core:test --tests "kafka.admin.AclCommandTest.testAclCliWithAuthorizer"`
* Result: all tests in `core` module are re-compiled
If test modified with `vim`, only single test class is re-compiled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1959250699
Backported to `3.7` branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "pasharik (via GitHub)" <gi...@apache.org>.
pasharik commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1526739190
##########
gradle/dependencies.gradle:
##########
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8.5",
+ gradle: "8.6",
Review Comment:
This PR has already been merged, but I'll leave a comment here ahyway.
I've noticed, what behaviour of incremental compilation for scala tests in gradle seems to be changed after gradle version upgrade from `8.5` to `8.6`.
With gradle `8.6`, if I do any change to some unit-test, e.g. `kafka.admin.AclCommandTest.scala`, and then run:
```
./gradlew core:compileTestScala
```
the entire folder `core/build/classes/scala/test` is cleared, and gradle re-compiles _all_ tests. It takes quite a long time. So the incremental compilation for scala tests seems to be broken.
If I change Gradle version back to `8.5`, incremental compilation works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1497338394
##########
gradlew:
##########
@@ -215,11 +215,11 @@ fi
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
-# Collect all arguments for the java command;
-# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
-# shell script including quotes and variable substitutions, so put them in
-# double quotes to make sure that they get re-expanded; and
-# * put everything else in single quotes, so that it's not re-expanded.
+# Collect all arguments for the java command:
Review Comment:
A similar change was made in another PR and turns out that these lines may not need to be changed. Here is a reference to @ijuma's comment about it https://github.com/apache/kafka/pull/14502#discussion_r1355560355
Can you please add what commands are you running that is leading to change in these lines?
##########
gradle/dependencies.gradle:
##########
@@ -103,7 +103,7 @@ versions += [
gradle: "8.5",
grgit: "4.1.1",
httpclient: "4.5.14",
- jackson: "2.16.0",
+ jackson: "2.16.1",
Review Comment:
please add jackson diff to the description of the PR for completeness - https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16.1
I have reviewed the diff and I don't see any problems in this patch version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-2007053721
I generated the wrapper the way `gradle` recommends (`./gradlew wrapper --gradle-version latest`). I would leave it the way gradle generates it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1528355399
##########
gradle/dependencies.gradle:
##########
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8.5",
+ gradle: "8.6",
Review Comment:
I see some inconsistencies with this report.
I managed to reproduce it only once. But when I tried it again, incremental compilation worked as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956432277
I would say `trunk` build is broken again. I'll investigate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "pasharik (via GitHub)" <gi...@apache.org>.
pasharik commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-2007048822
There is a version of gradle wrapper in our [gradlew](https://github.com/apache/kafka/blob/trunk/gradlew#L119) file:
```
https://raw.githubusercontent.com/gradle/gradle/v8.5.0/gradle/wrapper/gradle-wrapper.jar
```
should we update to `8.6.0` it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1497350416
##########
gradlew:
##########
@@ -215,11 +215,11 @@ fi
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
-# Collect all arguments for the java command;
-# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
-# shell script including quotes and variable substitutions, so put them in
-# double quotes to make sure that they get re-expanded; and
-# * put everything else in single quotes, so that it's not re-expanded.
+# Collect all arguments for the java command:
Review Comment:
This is what I run to upgrade to the latest version of Gradle (as per documentation): https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper
`./gradlew wrapper --gradle-version latest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #15404:
URL: https://github.com/apache/kafka/pull/15404#issuecomment-1959267158
Regarding a backport to the `3.6` branch, Gradle version over there is `8.2.1`, it's a bit of a jump I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Update dependencies [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat merged PR #15404:
URL: https://github.com/apache/kafka/pull/15404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org