You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "robertwb (via GitHub)" <gi...@apache.org> on 2023/05/19 16:51:19 UTC

[GitHub] [beam] robertwb commented on pull request #26778: Don't fail if creating a venv didn't succeed - CP of #26753

robertwb commented on PR #26778:
URL: https://github.com/apache/beam/pull/26778#issuecomment-1554897466

   Presumably the reason venv was added was to solve some problem (maybe mixing up of dependencies or something like that). Just falling back to not using it would cause it to (non-determanistically) exhibit the same issues that adding this was trying to solve. 
   
   Some alternatives would be to make it explicit whether venv should be used (either opt-in or opt-out) or make venv a requirement for Beam (if the user pre-installs beam) or at the very least give a clear error (e.g. "venv is required but not installed in this custom container). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org