[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #17271: Fix #17267, add expected and got datatype for concat error msgs

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365505412
 
 

 ##########
 File path: src/operator/nn/concat.cc
 ##########
 @@ -149,9 +149,10 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
     if (dtype == -1) {
       dtype = i;
     } else {
-      CHECK(i == dtype ||
-          i == -1) <<
-          "Non-uniform data type in Concat";
+      CHECK( i == dtype || i == -1) 
 
 Review comment:
   Thanks for the fix! Two suggestions: 
   - this function is used for both Concat and dstack. Can we extend the error msg to `Non-uniform data type in Concat / dstack.... ` ?
   - can we extend the last sentenve and show the index of the data type : `..... got data type x at position y`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services