You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2014/03/06 13:31:58 UTC
svn commit: r1574857 - in /hbase/branches/0.98:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
hbase-shell/src/test/ruby/hbase/table_test.rb
Author: apurtell
Date: Thu Mar 6 12:31:58 2014
New Revision: 1574857
URL: http://svn.apache.org/r1574857
Log:
HBASE-10080 Unnecessary call to locateRegion when creating an HTable instance (Nicolas Liochon)
Modified:
hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
Modified: hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java?rev=1574857&r1=1574856&r2=1574857&view=diff
==============================================================================
--- hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java (original)
+++ hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java Thu Mar 6 12:31:58 2014
@@ -323,7 +323,6 @@ public class HTable implements HTableInt
* setup this HTable's parameter based on the passed configuration
*/
private void finishSetup() throws IOException {
- this.connection.locateRegion(tableName, HConstants.EMPTY_START_ROW);
this.operationTimeout = tableName.isSystemTable() ?
this.configuration.getInt(HConstants.HBASE_CLIENT_META_OPERATION_TIMEOUT,
HConstants.DEFAULT_HBASE_CLIENT_OPERATION_TIMEOUT):
Modified: hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java?rev=1574857&r1=1574856&r2=1574857&view=diff
==============================================================================
--- hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java (original)
+++ hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java Thu Mar 6 12:31:58 2014
@@ -1281,7 +1281,9 @@ public class TestAdmin {
*/
@Test (expected=TableNotFoundException.class, timeout=300000)
public void testTableNotFoundExceptionWithoutAnyTables() throws IOException {
- new HTable(TEST_UTIL.getConfiguration(),"testTableNotFoundExceptionWithoutAnyTables");
+ HTable ht =
+ new HTable(TEST_UTIL.getConfiguration(),"testTableNotFoundExceptionWithoutAnyTables");
+ ht.get(new Get("e".getBytes()));
}
Modified: hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb
URL: http://svn.apache.org/viewvc/hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb?rev=1574857&r1=1574856&r2=1574857&view=diff
==============================================================================
--- hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb (original)
+++ hbase/branches/0.98/hbase-shell/src/test/ruby/hbase/table_test.rb Thu Mar 6 12:31:58 2014
@@ -29,12 +29,6 @@ module Hbase
setup_hbase
end
- define_test "Hbase::Table constructor should fail for non-existent tables" do
- assert_raise(NativeException) do
- table('non-existent-table-name')
- end
- end
-
define_test "Hbase::Table constructor should not fail for existent tables" do
assert_nothing_raised do
table('hbase:meta')