You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/02/19 14:12:43 UTC

Review Request 43762: Added a comment for `ShutdownProcess` in the executor library.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43762/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Ben Mahler.


Bugs: MESOS-1571
    https://issues.apache.org/jira/browse/MESOS-1571


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1 

Diff: https://reviews.apache.org/r/43762/diff/


Testing
-------

The complete chain was tested. See https://reviews.apache.org/r/43764/ .


Thanks,

Alexander Rukletsov

Re: Review Request 43762: Added a comment for `ShutdownProcess` in the executor library.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43762/#review120071
-----------------------------------------------------------


Ship it!




Thanks Alex, I'll get this in with an adjustment of the comment.


src/exec/exec.cpp (lines 75 - 81)
<https://reviews.apache.org/r/43762/#comment181440>

    How about this?
    
    ```
    // The ShutdownProcess is a relic of the pre-cgroup process isolation
    // days. It ensures that the executor process tree is killed after a
    // shutdown has been sent.
    //
    // TODO(bmahler): Update 'delay' to handle deferred callbacks without
    // needing a Process. This would eliminate the need for an explicit
    // Process here, see: MESOS-4729.
    ```
    
    I filed MESOS-4729 to avoid the need for a Process here.


- Ben Mahler


On Feb. 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43762/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-1571
>     https://issues.apache.org/jira/browse/MESOS-1571
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1 
> 
> Diff: https://reviews.apache.org/r/43762/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/43764/ .
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>