You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/26 00:06:07 UTC
Review Request 32500: Removed LAUNCH call from scheduler.proto.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
Removed LAUNCH call in favor of ACCEPT.
Diffs
-----
include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
Diff: https://reviews.apache.org/r/32500/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/
-----------------------------------------------------------
(Updated April 20, 2015, 7:58 p.m.)
Review request for mesos, Ben Mahler and Jie Yu.
Changes
-------
Alex's. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
Removed LAUNCH call in favor of ACCEPT.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc
src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
Diff: https://reviews.apache.org/r/32500/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> > include/mesos/scheduler/scheduler.proto, line 171
> > <https://reviews.apache.org/r/32500/diff/2/?file=910129#file910129line171>
> >
> > Do we specify an order in which offer operations are performed? I don't think you touched this in the design doc. Mind leaving a comment whether we provide any guarantees here?
it performs them in the sequential order, as specifed at the top.
> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> > src/scheduler/scheduler.cpp, lines 316-321
> > <https://reviews.apache.org/r/32500/diff/2/?file=910133#file910133line316>
> >
> > IIUC, since this is not migrated to `case Call::ACCEPT`, tasks are launched via `Master::accept()` and not via `Master::launchTasks()`. If this is the case, then it looks like we do not update some metrics, namely:
> > `++metrics->messages_launch_tasks;`
> > `++metrics->messages_decline_offers;`
> >
> > Do you plan to adress this later on or am I missing something?
Good catch. Added a TODO for now. I plan to do it once the old driver is completely migrated to send Calls.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/#review79351
-----------------------------------------------------------
On March 30, 2015, 11:59 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32500/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 11:59 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed LAUNCH call in favor of ACCEPT.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
> src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
>
> Diff: https://reviews.apache.org/r/32500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/#review79351
-----------------------------------------------------------
include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/32500/#comment128617>
FYI: this looks too long for a comment, clang-format shouldn't allow this. I think this is OK though, and helps readability.
include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/32500/#comment128614>
Do we specify an order in which offer operations are performed? I don't think you touched this in the design doc. Mind leaving a comment whether we provide any guarantees here?
src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/32500/#comment128615>
IIUC, since this is not migrated to `case Call::ACCEPT`, tasks are launched via `Master::accept()` and not via `Master::launchTasks()`. If this is the case, then it looks like we do not update some metrics, namely:
`++metrics->messages_launch_tasks;`
`++metrics->messages_decline_offers;`
Do you plan to adress this later on or am I missing something?
- Alexander Rukletsov
On March 30, 2015, 11:59 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32500/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 11:59 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed LAUNCH call in favor of ACCEPT.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
> src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
>
> Diff: https://reviews.apache.org/r/32500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/
-----------------------------------------------------------
(Updated March 30, 2015, 11:59 p.m.)
Review request for mesos, Ben Mahler and Jie Yu.
Changes
-------
rebased and addressed comments. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
Removed LAUNCH call in favor of ACCEPT.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b
src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
Diff: https://reviews.apache.org/r/32500/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 26, 2015, 12:51 a.m., Ben Mahler wrote:
> > include/mesos/scheduler/scheduler.proto, line 124
> > <https://reviews.apache.org/r/32500/diff/1/?file=906076#file906076line124>
> >
> > Ditto here, the tag numbers don't matter much, but are you planning to fill in the holes since we're breaking this?
Yea. I fixed them in the final review of this chain.
> On March 26, 2015, 12:51 a.m., Ben Mahler wrote:
> > include/mesos/scheduler/scheduler.proto, line 222
> > <https://reviews.apache.org/r/32500/diff/1/?file=906076#file906076line222>
> >
> > Just curious, are you planning on updating the tag numbers at some point or just going to leave the holes?
see above.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/#review77836
-----------------------------------------------------------
On March 25, 2015, 11:06 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32500/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed LAUNCH call in favor of ACCEPT.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
> src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
>
> Diff: https://reviews.apache.org/r/32500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/#review77836
-----------------------------------------------------------
Ship it!
include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/32500/#comment126165>
Ditto here, the tag numbers don't matter much, but are you planning to fill in the holes since we're breaking this?
include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/32500/#comment126164>
Just curious, are you planning on updating the tag numbers at some point or just going to leave the holes?
src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/32500/#comment126163>
Ditto here, maybe some newlines to make this a bit more readable?
src/examples/low_level_scheduler_pthread.cpp
<https://reviews.apache.org/r/32500/#comment126160>
newline here?
src/examples/low_level_scheduler_pthread.cpp
<https://reviews.apache.org/r/32500/#comment126161>
newline here?
src/examples/low_level_scheduler_pthread.cpp
<https://reviews.apache.org/r/32500/#comment126162>
newline here?
src/tests/scheduler_tests.cpp
<https://reviews.apache.org/r/32500/#comment126158>
newline here?
src/tests/scheduler_tests.cpp
<https://reviews.apache.org/r/32500/#comment126159>
newline here?
- Ben Mahler
On March 25, 2015, 11:06 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32500/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed LAUNCH call in favor of ACCEPT.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
> src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
>
> Diff: https://reviews.apache.org/r/32500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32500: Removed LAUNCH call from scheduler.proto.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32500/#review77896
-----------------------------------------------------------
Ship it!
LGTM
- Alexander Rojas
On March 26, 2015, 12:06 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32500/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 12:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed LAUNCH call in favor of ACCEPT.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
> src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
>
> Diff: https://reviews.apache.org/r/32500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>