You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "joel-hamill (via GitHub)" <gi...@apache.org> on 2024/03/08 20:44:46 UTC
[PR] Fix incorrect syntax for config [kafka]
joel-hamill opened a new pull request, #15500:
URL: https://github.com/apache/kafka/pull/15500
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
Fixed improper syntax which renders improperly in the downstream output.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix incorrect syntax for config [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #15500:
URL: https://github.com/apache/kafka/pull/15500#discussion_r1518395847
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -285,8 +285,10 @@ public class ProducerConfig extends AbstractConfig {
"<ul>" +
"<li>If not set, the default partitioning logic is used. " +
"This strategy send records to a partition until at least " + BATCH_SIZE_CONFIG + " bytes is produced to the partition. It works with the strategy:" +
- "<p> 1) If no partition is specified but a key is present, choose a partition based on a hash of the key." +
- "<p> 2) If no partition or key is present, choose the sticky partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are produced to the partition." +
+ "<ol>" +
+ "<li>If no partition is specified but a key is present, choose a partition based on a hash of the key." +
Review Comment:
```suggestion
"<li>If no partition is specified but a key is present, choose a partition based on a hash of the key.</li>" +
```
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -285,8 +285,10 @@ public class ProducerConfig extends AbstractConfig {
"<ul>" +
"<li>If not set, the default partitioning logic is used. " +
"This strategy send records to a partition until at least " + BATCH_SIZE_CONFIG + " bytes is produced to the partition. It works with the strategy:" +
- "<p> 1) If no partition is specified but a key is present, choose a partition based on a hash of the key." +
- "<p> 2) If no partition or key is present, choose the sticky partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are produced to the partition." +
+ "<ol>" +
+ "<li>If no partition is specified but a key is present, choose a partition based on a hash of the key." +
+ "<li>If no partition or key is present, choose the sticky partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are produced to the partition." +
Review Comment:
```suggestion
"<li>If no partition or key is present, choose the sticky partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are produced to the partition.</li>" +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix incorrect syntax for config [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #15500:
URL: https://github.com/apache/kafka/pull/15500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix incorrect syntax for config [kafka]
Posted by "joel-hamill (via GitHub)" <gi...@apache.org>.
joel-hamill commented on PR #15500:
URL: https://github.com/apache/kafka/pull/15500#issuecomment-1986393715
cc @cherylws
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix incorrect syntax for config [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #15500:
URL: https://github.com/apache/kafka/pull/15500#issuecomment-1989056918
Merged to `trunk` and cherry-picked to `3.7` and `3.6` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org