[GitHub] [iceberg] rdblue commented on pull request #3965: implement __eq__ for iceberg type classes.

[GitBox <gi...@apache.org>]

rdblue commented on pull request #3965:
URL: https://github.com/apache/iceberg/pull/3965#issuecomment-1024584042


   @jun-he, the `__eq__` implementations look good to me. It would be good to fix some of the test suggestions that @emkornfield pointed out, along with fixing hash functions. In Java, you always override hash functions if you override equality and I don't see why you wouldn't in Python as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org