[jira] [Commented] (GROOVY-8060) @Log annotation does not check logging enablement inside closures which are arguments to methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834315#comment-15834315 ] 

ASF GitHub Bot commented on GROOVY-8060:
----------------------------------------

GitHub user paulk-asert opened a pull request:

    https://github.com/apache/groovy/pull/478

    GROOVY-8060: @Log annotation does not check logging enablement inside…

    … closures which are arguments to methods

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paulk-asert/groovy groovy8060

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #478
    
----
commit e96a9619ca3e51d867290056194fe5259c55c084
Author: paulk <pa...@asert.com.au>
Date:   2017-01-23T11:42:52Z

    GROOVY-8060: @Log annotation does not check logging enablement inside closures which are arguments to methods

----


> @Log annotation does not check logging enablement inside closures which are arguments to methods
> ------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-8060
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8060
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-runtime
>    Affects Versions: 2.3.3, 2.4.8
>         Environment: Windows 7, Groovy 2.3.3, JDK 1.8.0_05
>            Reporter: Shorn
>            Assignee: Paul King
>            Priority: Minor
>
> From cloned issue for an additional case:
> {code}
> import groovy.util.logging.Slf4j
> import spock.lang.Specification
> @Slf4j
> class LoggingSpec extends Specification {
>     def "makes sure groovy isn't building the string inside inactive log levels"() {
>         assert log.isDebugEnabled() == false, "set the log level for this class to INFO to see the horror"
>         assert log.isInfoEnabled() == true, "set the log level for this class to INFO to see the horror"
>         CountingDoIt counter = new CountingDoIt()
>         //http://docs.groovy-lang.org/docs/groovy-2.4.5/html/documentation/#_logging_improvements
>         when: "we shouldn't evaluate"
>         log.debug("this shouldn't happen ${counter.call()}".toString())
>         then:
>         counter.count == 0
>         when: "we should evaluate"
>         counter = new CountingDoIt()
>         log.info("this should happen ${counter.call()}".toString())
>         then:
>         counter.count == 1
>         when: "we're inside a closure and groovy is failing..so beware"
>         counter = new CountingDoIt()
>         1.times({ ignore ->
>             log.debug(counter.call())
>         })
>         then:
>         counter.count == 0    //debug isn't enabled so this string should never be evaluated but it is
>         when: "we're inside a closure that calls a method.  it's OK"
>         counter = new CountingDoIt()
>         1.times({ ignore ->
>             log.debug("this shouldn't happen ${doIt(counter)}".toString())
>         })
>         then:
>         counter.count == 0
>     }
>     String doIt(CountingDoIt countingDoIt) {
>         log.debug("this shouldn't happen ${countingDoIt.call()}".toString())
>         "blah"
>     }
>     static class CountingDoIt {
>         int count = 0
>         String call() {
>             count = count + 1
>             "doneDidIt"
>         }
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)