You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2026/07/16 13:00:54 UTC
[PR] Generate documentation for vended credentials [polaris]
adutra opened a new pull request, #5070:
URL: https://github.com/apache/polaris/pull/5070
This change introduces a new "Vended Credentials Reference" page in Polaris website, automatically generated from the authoritative `StorageAccessProperty` enum constants.
Other changes:
- Removed unused `AZURE_ACCESS_TOKEN` enum constant
- Removed redundant `EXPIRATION_TIME` enum constant (no client consumes such a property)
- Reworked and renamed Azure's prefixed properties for clarity.
- Renamed expiration time properties for better naming alignment.
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up and document vended credential properties [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3606155322
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
One last comment ๐
Should be mention this in CHANGELOG? I hope no client depends on this property, but technically it is a major change in catalog behaviour ๐ค
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3597200979
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
@flyrain @dennishuo @collado-mike : Any insight? The constant appears to be present since #1 :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3598707824
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
> Let's remove EXPIRATION_TIME in a dedicated PR for the sake of clarity
That complicates things quite a bit ๐
How about instead we change the PR and commit title to "Clean up and document vended credential properties"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up and document vended credential properties [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3606155322
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
One last comment ๐
Should we mention this in CHANGELOG? I hope no client depends on this property, but technically it is a major change in catalog behaviour ๐ค
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up and document vended credential properties [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3606676447
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
+1 on adding it to the changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3595745645
##########
site/content/in-dev/unreleased/configuration/config-sections/smallrye-polaris_idempotency.md:
##########
@@ -0,0 +1,33 @@
+---
Review Comment:
See #5069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3599404513
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
I'm OK with both as well, just be aware of how we make the reviewers life a bit easier. Due to the volume of the PRs, keeping the review quality is pretty challenges TBH. Smaller PRs naturally lead to higher review quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3596063156
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
Why are we removing `EXPIRATION_TIME` is a "docs" PR ๐ค
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
Why are we removing `EXPIRATION_TIME` in a "docs" PR? ๐ค
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up and document vended credential properties [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #5070:
URL: https://github.com/apache/polaris/pull/5070#issuecomment-5035856281
> Should we mention this in CHANGELOG? I hope no client depends on this property, but technically it is a major change in catalog behaviour ๐ค
Done, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up and document vended credential properties [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #5070:
URL: https://github.com/apache/polaris/pull/5070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3597969395
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
Sounds good to me :+1: Minor ask: Let's remove `EXPIRATION_TIME` in a dedicated PR for the sake of clarity, then rebase the docs PR. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3598761384
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
That works too :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3596157313
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
Because I couldn't find any client consuming it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3597337919
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
It doesn't seem quite useful to me as cloud storage provider have their own properties, like `AWS_SESSION_TOKEN_EXPIRES_AT_MS`, `GCS_ACCESS_TOKEN_EXPIRES_AT`, `AZURE_SAS_TOKEN_EXPIRES_AT_MS_PREFIX`. The IRC spec doesn't require it(`expiration-time`) as well. Maybe we can double check with IRC clients(e.g., Spark, Trino), I'd suggest to remove it if clients don't honor it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3595664908
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java:
##########
@@ -263,8 +263,6 @@ static StorageAccessConfig toAccessConfig(
Optional<String> refreshCredentialsEndpoint) {
StorageAccessConfig.Builder accessConfig = StorageAccessConfig.builder();
handleAzureCredential(accessConfig, sasToken, location, expiresAt);
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(expiresAt.toEpochMilli()));
refreshCredentialsEndpoint.ifPresent(
Review Comment:
`toAccessConfig` no longer sets `StorageAccessConfig.expiresAt`, because the only remaining timestamp is written via `putCredential(String,String)` with a suffixed key. This means `storageAccessConfig.expiresAt()` will be empty for Azure credentials and cache entries may effectively never expire.
##########
site/content/in-dev/unreleased/vended-credentials.md:
##########
@@ -0,0 +1,96 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+title: Vended Credentials Reference
+linkTitle: Vended Credentials Reference
+type: docs
+weight: 460
+---
+
+When an Iceberg client (Spark, Trino, PyIceberg, etc.) loads a table or view, Polaris can be
+configured to return short-lived, scoped credentials that the client uses to access cloud storage
+directly. These credentials are returned as key-value properties in the Iceberg REST API response
+(see `LoadTableResult` and `LoadViewResult` in the [Iceberg REST
+spec](https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml)).
+
+Properties with kind `credential` carry sensitive material and are returned in the `credentials`
+map of the API response (never logged). Properties with kind `config` carry non-sensitive
+configuration and are returned in the `config` map.
+
+There is no standard that defines common property names for vended credentials. The names Polaris
+uses match what the Iceberg SDK expects for each storage type. This page documents the exact
+property names Polaris emits so that client authors and operators can diagnose authentication
+failures and understand client compatibility.
+
+## AWS S3
+
+Polaris calls [AWS STS `AssumeRole`](https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html)
+with an inline session policy scoped to the specific table locations and operations (read, list,
+write) the caller is authorized to perform. The resulting temporary credentials are returned to the
+client.
+
+{{% include-config-section "storage-aws" %}}
+
+## Azure ADLS
+
+Polaris generates a
+[User Delegation SAS token](https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blob-user-delegation-sas-create-dotnet)
+scoped to the container and path prefix the caller is authorized to access. Azure limits the
+maximum validity of a User Delegation SAS token to **seven days**.
+
+{{% include-config-section "storage-azure" %}}
+
+{{< alert note >}}
+The suffixed key forms (`adls.sas-token.<account-host>` and `adls.sas-token.<account-name>`) always
+carry the same SAS token. Polaris emits all forms simultaneously so that different clients can each
Review Comment:
These lines end with trailing whitespace, which can cause unintended hard line breaks in Markdown and may fail whitespace/lint checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3595729905
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/azure/AzureCredentialsStorageIntegration.java:
##########
@@ -263,8 +263,6 @@ static StorageAccessConfig toAccessConfig(
Optional<String> refreshCredentialsEndpoint) {
StorageAccessConfig.Builder accessConfig = StorageAccessConfig.builder();
handleAzureCredential(accessConfig, sasToken, location, expiresAt);
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(expiresAt.toEpochMilli()));
refreshCredentialsEndpoint.ifPresent(
Review Comment:
Good point, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generate documentation for vended credentials [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3597969395
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
Sounds good to me :+1: Minor ask: Let's remove `EXPIRATION_TIME` is a dedicated PR for the sake of clarity, then rebase the docs PR. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up and document vended credential properties [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #5070:
URL: https://github.com/apache/polaris/pull/5070#discussion_r3604155252
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -255,13 +255,10 @@ static StorageAccessConfig compute(AwsStorageCredentialCacheKey key) {
accessConfig.put(StorageAccessProperty.AWS_TOKEN, response.credentials().sessionToken());
Optional.ofNullable(response.credentials().expiration())
.ifPresent(
- i -> {
- accessConfig.put(
- StorageAccessProperty.EXPIRATION_TIME, String.valueOf(i.toEpochMilli()));
Review Comment:
Thank you both for your understanding. I changed the PR title and the commit message to better reflect the changes.
I'll keep in mind to produce smaller PRs in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org