[GitHub] [iceberg] stevenzwu commented on a change in pull request #3998: Flink: support overwrite configuration in the flink sink action

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r797292534



##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -430,6 +440,19 @@ private String operatorName(String suffix) {
           throw new RuntimeException("Unrecognized write.distribution-mode: " + writeMode);
       }
     }
+
+    private void buildProperties() {
+      if (table == null) {
+        return;
+      }
+      if (this.props.isEmpty()) {
+        this.props = table.properties();
+      } else {
+        Map<String, String> result = Maps.newHashMap(this.table.properties());
+        this.props.forEach((key, value) -> result.merge(key, value, (v1, v2) -> v2));

Review comment:
       is it simpler to just do `result.put(key, value)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org