[Impala-ASF-CR] IMPALA-10283: Fix IllegalStateException in applying incremental partition updates

["Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>]

Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16649 )

Change subject: IMPALA-10283: Fix IllegalStateException in applying incremental partition updates
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16649/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16649/2//COMMIT_MSG@14
PS2, Line 14: aka
nit, replacing with "via" makes more sense to me.


http://gerrit.cloudera.org:8080/#/c/16649/2//COMMIT_MSG@28
PS2, Line 28: So one of the coordinator will have a table version
            : that is lower than the latest version in catalogd but larger than the
            : last sent table version in catalogd
IIUC, we are saying that the table in the coordinator cache is already at a later version (due to DML response) than one in the topic-update? In this case shouldn't we be skipping the table altogether here https://github.com/apache/impala/blob/c3b5cf8b4c807fa4136b64addb1e7e8be8aaf6c5/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java#L472 since the thrift table's version is lower than the table version in the coordinator cache?



-- 
To view, visit http://gerrit.cloudera.org:8080/16649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1657684f8853b76b1524475a3b3c35fa22a0e36e
Gerrit-Change-Number: 16649
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Nov 2020 18:44:44 +0000
Gerrit-HasComments: Yes