[GitHub] [incubator-pinot] npawar commented on a change in pull request #5320: Use time column from table config instead of schema

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #5320:
URL: https://github.com/apache/incubator-pinot/pull/5320#discussion_r418356187



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java
##########
@@ -85,7 +85,10 @@ public File purgeSegment()
       }
 
       Schema schema = purgeRecordReader.getSchema();
-      SegmentGeneratorConfig config = new SegmentGeneratorConfig(schema);
+      // FIXME: figure out how to get table config here.

Review comment:
       As per offline discussion with @Jackie-Jiang  removing the timeColumnName from SegmentPurger for now. He will be working on a fix to make TableConfig available to SegmentPurger very soon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org